Skip to content

feat(crd): feat(crd): add service account CRD - #68

Merged
jaypipes merged 2 commits into
mainfrom
tomba/add-service-account
Nov 6, 2026
Merged

jaypipes merged 2 commits into
mainfrom
tomba/add-service-account

Conversation

@tomba7

@tomba7 tomba7 commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator
  • Added the ServiceAccount CRD
  • Renamed ProjectReferenceOrID to a generic ResourceReferenceOrID
  • Changed the namespace and project access field types from map defined in the protobuf (Access, ProjectScopedAccess) to list in the CRD, to enable lookup by ref.
  • Added status.references following the status shape agreed in #67.
    • For the ServiceAccount, I've put the resolved IDs mirrored by the spec paths, because the same kind of ID can come from different access scopes.

Examples:
#54 (comment)

Quick follow

  • From/To Proto helpers and unit tests
  • Reconciler implementations

@tomba7
tomba7 requested a review from jaypipes as a code owner November 6, 2026 19:55
Comment thread api/cloud/v1alpha1/service_account.go Resolved
Comment thread api/cloud/v1alpha1/service_account.go Resolved
Comment thread api/cloud/v1alpha1/service_account.go Resolved
Comment thread api/cloud/v1alpha1/service_account.go Resolved

@jaypipes jaypipes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaypipes
jaypipes merged commit f7ac9cc into main Nov 6, 2026
7 checks passed
@jaypipes
jaypipes deleted the tomba/add-service-account branch November 6, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants