Add Shipwright Build and Shared Resource extension by sayan-biswas · Pull Request #4130 · tektoncd/operator

sayan-biswas · 2026-09-21T13:06:42Z

Changes

Adds two new operator-managed components: ShipwrightBuild and SharedResource.

New CRDs & API types — ShipwrightBuild and SharedResource added to pkg/apis/operator/v1alpha1/ (types, defaults, lifecycle, validation), registered in the scheme (register.go) with resource-name constants and the one-CR-per-type Validate() check.
ShipwrightBuild component — Kubernetes reconciler + transformer and an OpenShift extension/controller, wired through TektonConfig on both platforms. Installs the Shipwright Build controller.
SharedResource component — OpenShift-only reconciler, extension, controller, and transformer, plus NetworkPolicies and service-CA handling.
OpenShift service-CA helper — new pkg/reconciler/openshift/common/serviceca.go for injecting the service CA bundle.
Platform wiring — registered both components in TektonConfig extensions (Kubernetes & OpenShift), platform constants, the webhook, and the shared/init controllers.
RBAC / config — updates to config/base/role.yaml, kustomization, and operator manifests.
Tests — unit tests for reconcilers, transformers, validation, lifecycle, NetworkPolicies, and service-CA; e2e tests and test/resources / test/utils helpers for both new components.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Run make test lint before submitting a PR
Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

Add support for installing and managing the Shipwright Build and SharedResource components via the Tekton Operator.

tekton-robot · 2026-09-21T13:06:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pramodbindal after the PR has been reviewed.
You can assign the PR to them by writing /assign @pramodbindal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov · 2026-09-21T13:12:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.78%. Comparing base (4bf6f29) to head (3ab2bdc).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4130      +/-   ##
==========================================
- Coverage   30.82%   30.78%   -0.04%     
==========================================
  Files         478      526      +48     
  Lines       23418    25387    +1969     
==========================================
+ Hits         7218     7815     +597     
- Misses      16200    17572    +1372

Flag	Coverage Δ
unit-tests	`30.78% <ø> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jkhelil

Add shipwrightbuildinformer + sharedresourceinformer event handlers with FilterController(&v1alpha1.TektonConfig{}) exactly like TektonChain. in pkg/reconciler/shared/tektonconfig/controller.go

jkhelil · 2026-10-26T13:54:34Z

@sayan-biswas you probably need to add network policies also to your implementation

sayan-biswas · 2026-11-01T22:07:19Z

@sayan-biswas you probably need to add network policies also to your implementation

Network policies were there in the manifests, but I've removed them and added from the code like other components.

Copilot

🟡 Changes recommended

Critical RBAC gaps, missing Kubernetes Helm CRDs, and webhook TLS defects block installation or operation, while incomplete namespace validation permits adoption of protected namespaces.

25 open issues

And 5 more that still need to be addressed.

2 files not reviewed

pkg/apis/operator/v1alpha1/zz_generated.deepcopy.go: Generated file
pkg/client/clientset/versioned/typed/operator/v1alpha1/fake/fake_operator_client.go: Generated file

What changed in this PR

Adds operator-managed Shipwright Build support on Kubernetes and OpenShift, plus an OpenShift-only SharedResource CSI component, integrated with TektonConfig and InstallerSets.

Changes:

Adds component APIs, lifecycle helpers, validation, and generated clients and informers.
Wires platform controllers, manifest transformations, certificates, and NetworkPolicies.
Extends release fetching, CRD/RBAC packaging, deployment configuration, and unit/e2e tests.

This pull request requires changes. Unresolved findings affect installation permissions and packaging, namespace validation, webhook TLS, reconciliation and readiness, configuration propagation, release selection, and test reliability.

File	Description
`test/utils/names.go`	Adds resource names for both components.
`test/utils/e2e_flags.go`	Adds component deployment label selectors.
`test/utils/clients.go`	Exposes typed component test clients.
`test/utils/cleanup.go`	Adds component teardown helpers.
`test/resources/shipwrightbuilds.go`	Adds Shipwright lifecycle test helpers.
`test/resources/sharedresources.go`	Adds SharedResource lifecycle test helpers.
`test/e2e/openshift/shipwrightbuild_test.go`	Adds OpenShift Shipwright installation and deletion tests.
`test/e2e/openshift/sharedresource_test.go`	Adds SharedResource lifecycle and deployment-recovery tests.
`test/e2e/kubernetes/shipwrightbuild_test.go`	Adds Kubernetes Shipwright lifecycle and recovery tests.
`pkg/webhook/webhook.go`	Registers both admission API types.
`pkg/reconciler/shared/tektonconfig/shipwrightbuild/shipwrightbuild_test.go`	Tests TektonConfig-driven Shipwright management.
`pkg/reconciler/shared/tektonconfig/sharedresource/sharedresource_test.go`	Tests TektonConfig-driven SharedResource management.
`pkg/reconciler/shared/tektonconfig/controller.go`	Watches both component CRs.
`pkg/reconciler/platform/const.go`	Defines component controller names.
`pkg/reconciler/openshift/tektonconfig/extension.go`	Adds reconciliation and teardown for both components.
`pkg/reconciler/openshift/shipwrightbuild/networkpolicies.go`	Defines Shipwright workload NetworkPolicies.
`pkg/reconciler/openshift/shipwrightbuild/networkpolicies_test.go`	Tests Shipwright policy construction.
`pkg/reconciler/openshift/shipwrightbuild/controller.go`	Connects the OpenShift Shipwright extension.
`pkg/reconciler/openshift/shipwrightbuild/common.go`	Defines webhook TLS flag constants.
`pkg/reconciler/openshift/sharedresource/transformer.go`	Adds SharedResource manifest transformations.
`pkg/reconciler/openshift/sharedresource/reconciler.go`	Implements SharedResource installation, status, and finalization.
`pkg/reconciler/openshift/sharedresource/networkpolicies.go`	Defines CSI driver and webhook NetworkPolicies.
`pkg/reconciler/openshift/sharedresource/networkpolicies_test.go`	Tests SharedResource policy construction.
`pkg/reconciler/openshift/sharedresource/extension.go`	Adds OpenShift TLS, metrics, and policy hooks.
`pkg/reconciler/openshift/sharedresource/extension_test.go`	Tests extension hooks and transformations.
`pkg/reconciler/openshift/sharedresource/controller.go`	Initializes SharedResource manifests and watches.
`pkg/reconciler/openshift/sharedresource/common.go`	Defines workload, metrics, and TLS identifiers.
`pkg/reconciler/openshift/openshiftplatform/config.go`	Registers both OpenShift component controllers.
`pkg/reconciler/openshift/common/serviceca.go`	Adds service-CA annotation transformers.
`pkg/reconciler/openshift/common/serviceca_test.go`	Tests service-CA annotation behavior.
`pkg/reconciler/kubernetes/tektonconfig/extension.go`	Adds TektonConfig-driven Shipwright management.
`pkg/reconciler/kubernetes/shipwrightbuild/transformer.go`	Adds Shipwright payload and webhook-argument transformations.
`pkg/reconciler/kubernetes/shipwrightbuild/transformer_test.go`	Tests manifest filtering and argument injection.
`pkg/reconciler/kubernetes/shipwrightbuild/extension.go`	Adds Kubernetes webhook certificate provisioning.
`pkg/reconciler/kubernetes/shipwrightbuild/controller.go`	Initializes Shipwright payloads, strategies, and watches.
`pkg/reconciler/kubernetes/shipwrightbuild/common.go`	Defines workload constants and webhook Secret provisioning.
`pkg/reconciler/kubernetes/shipwrightbuild/common_test.go`	Tests webhook Secret creation and reuse.
`pkg/reconciler/kubernetes/kubernetesplatform/config.go`	Registers the Kubernetes Shipwright controller.
`pkg/reconciler/common/transformers.go`	Adds image prefixes and container-argument injection.
`pkg/reconciler/common/transformer_add_container_args_test.go`	Tests container-argument transformation behavior.
`pkg/reconciler/common/testdata/kodata/shipwright-build/0.21.0/release.yaml`	Adds a Shipwright release-discovery fixture.
`pkg/reconciler/common/testdata/kodata/shipwright-build/0.20.0/release.yaml`	Adds an older Shipwright release fixture.
`pkg/reconciler/common/testdata/kodata/shared-resource/0.2.0/release.yaml`	Adds a SharedResource release-discovery fixture.
`pkg/reconciler/common/testdata/kodata/shared-resource/0.1.0/release.yaml`	Adds an older SharedResource release fixture.
`pkg/reconciler/common/releases.go`	Maps component types to payload directories.
`pkg/reconciler/common/releases_test.go`	Tests release discovery for both components.
`pkg/reconciler/common/initcontroller.go`	Registers component payload loading.
`pkg/reconciler/common/common.go`	Adds manifest resource-kind constants.
`pkg/reconciler/common/certificates.go`	Adds configurable-duration certificate Secret generation.
`pkg/reconciler/common/certificates_test.go`	Tests generated certificate Secret contents.
`pkg/common/scc.go`	Uses the injected client configuration for security clients.
`pkg/client/listers/operator/v1alpha1/shipwrightbuild.go`	Adds the generated Shipwright lister.
`pkg/client/listers/operator/v1alpha1/sharedresource.go`	Adds the generated SharedResource lister.
`pkg/client/listers/operator/v1alpha1/expansion_generated.go`	Adds component lister expansion interfaces.
`pkg/client/injection/reconciler/operator/v1alpha1/shipwrightbuild/state.go`	Adds generated Shipwright reconciliation state handling.
`pkg/client/injection/reconciler/operator/v1alpha1/shipwrightbuild/controller.go`	Adds generated Shipwright controller wiring.
`pkg/client/injection/reconciler/operator/v1alpha1/sharedresource/state.go`	Adds generated SharedResource reconciliation state handling.
`pkg/client/injection/reconciler/operator/v1alpha1/sharedresource/controller.go`	Adds generated SharedResource controller wiring.
`pkg/client/injection/informers/operator/v1alpha1/shipwrightbuild/shipwrightbuild.go`	Adds Shipwright informer injection.
`pkg/client/injection/informers/operator/v1alpha1/shipwrightbuild/filtered/shipwrightbuild.go`	Adds filtered Shipwright informer injection.
`pkg/client/injection/informers/operator/v1alpha1/shipwrightbuild/filtered/fake/fake.go`	Adds filtered fake Shipwright informer injection.
`pkg/client/injection/informers/operator/v1alpha1/shipwrightbuild/fake/fake.go`	Adds fake Shipwright informer injection.
`pkg/client/injection/informers/operator/v1alpha1/sharedresource/sharedresource.go`	Adds SharedResource informer injection.
`pkg/client/injection/informers/operator/v1alpha1/sharedresource/filtered/sharedresource.go`	Adds filtered SharedResource informer injection.
`pkg/client/injection/informers/operator/v1alpha1/sharedresource/filtered/fake/fake.go`	Adds filtered fake SharedResource informer injection.
`pkg/client/injection/informers/operator/v1alpha1/sharedresource/fake/fake.go`	Adds fake SharedResource informer injection.
`pkg/client/informers/externalversions/operator/v1alpha1/interface.go`	Exposes both typed component informers.
`pkg/client/informers/externalversions/generic.go`	Registers generic component informer lookup.
`pkg/client/clientset/versioned/typed/operator/v1alpha1/shipwrightbuild.go`	Adds the generated Shipwright API client.
`pkg/client/clientset/versioned/typed/operator/v1alpha1/sharedresource.go`	Adds the generated SharedResource API client.
`pkg/client/clientset/versioned/typed/operator/v1alpha1/operator_client.go`	Exposes both component clients.
`pkg/client/clientset/versioned/typed/operator/v1alpha1/generated_expansion.go`	Adds component client expansion interfaces.
`pkg/client/clientset/versioned/typed/operator/v1alpha1/fake/fake_shipwrightbuild.go`	Adds the fake Shipwright API client.
`pkg/client/clientset/versioned/typed/operator/v1alpha1/fake/fake_sharedresource.go`	Adds the fake SharedResource API client.
`pkg/client/clientset/versioned/typed/operator/v1alpha1/fake/fake_operator_client.go`	Exposes both fake component clients.
`pkg/apis/operator/v1alpha1/shipwrightbuild_validation.go`	Adds Shipwright singleton-name validation.
`pkg/apis/operator/v1alpha1/shipwrightbuild_validation_test.go`	Tests Shipwright name and deletion validation.
`pkg/apis/operator/v1alpha1/shipwrightbuild_types.go`	Defines the Shipwright component API and configuration.
`pkg/apis/operator/v1alpha1/shipwrightbuild_lifecycle.go`	Adds Shipwright condition and status helpers.
`pkg/apis/operator/v1alpha1/shipwrightbuild_lifecycle_test.go`	Tests Shipwright lifecycle status transitions.
`pkg/apis/operator/v1alpha1/shipwrightbuild_defaults.go`	Adds the Shipwright defaulting hook.
`pkg/apis/operator/v1alpha1/sharedresource_validation.go`	Adds SharedResource singleton-name validation.
`pkg/apis/operator/v1alpha1/sharedresource_validation_test.go`	Tests SharedResource name and deletion validation.
`pkg/apis/operator/v1alpha1/sharedresource_types.go`	Defines the SharedResource component API and configuration.
`pkg/apis/operator/v1alpha1/sharedresource_lifecycle.go`	Adds SharedResource condition and status helpers.
`pkg/apis/operator/v1alpha1/sharedresource_lifecycle_test.go`	Tests SharedResource lifecycle status transitions.
`pkg/apis/operator/v1alpha1/sharedresource_defaults.go`	Adds the SharedResource defaulting hook.
`pkg/apis/operator/v1alpha1/register.go`	Registers both component API kinds and lists.
`pkg/apis/operator/v1alpha1/openshift_platform.go`	Exposes both components in OpenShift configuration.
`pkg/apis/operator/v1alpha1/kubernetes_platform.go`	Exposes Shipwright in Kubernetes configuration.
`pkg/apis/operator/v1alpha1/const.go`	Defines singleton component resource names.
`Makefile`	Simplifies progress-message punctuation.
`hack/sync-helm-crds.sh`	Adds both component CRDs to OpenShift Helm synchronization.
`hack/openshift/fetch-build-strategies.sh`	Adds semantic-version tag-selection tooling.
`hack/fetch-releases.sh`	Adds component and platform-specific payload fetching.
`config/openshift/base/operator.yaml`	Enables both OpenShift component controllers.
`config/kubernetes/base/operator.yaml`	Enables the Kubernetes Shipwright controller.
`config/base/role.yaml`	Adds Shipwright build-strategy permissions.
`config/base/kustomization.yaml`	Includes both generated component CRDs.
`config/base/generated-crds/operator.tekton.dev_tektonconfigs.yaml`	Adds platform configuration schema fields.
`components.yaml`	Defines component repositories and release versions.

_{Review effort: Balanced}

+	if !ok {
+		t.Fatal("Failed to get caller information")
+	}
+	m, err := mfc.NewManifest(filepath.Join((filepath.Dir(b)+"/.."), "manifests/"), clients.Config)


+
+// AssertShipwrightBuildInstallerSets verifies if the TektonInstallerSets are created.
+func AssertShipwrightBuildInstallerSets(t *testing.T, clients *utils.Clients) {
+	assertInstallerSets(t, clients, v1alpha1.ShipwrightBuildResourceName)


sayan-biswas · 2026-11-03T15:46:32Z

+	if !ok {
+		t.Fatal("Failed to get caller information")
+	}
+	m, err := mfc.NewManifest(filepath.Join((filepath.Dir(b)+"/.."), "manifests/"), clients.Config)


same as Jawed's comment below.

jkhelil · 2026-11-02T08:00:26Z

+	if !ok {
+		t.Fatal("Failed to get caller information")
+	}
+	m, err := mfc.NewManifest(filepath.Join((filepath.Dir(b)+"/.."), "manifests/"), clients.Config)


filepath.Dir(b) resolves to test/resources/, so the path becomes test/manifests/. That directory only contains tekton-pipeline, there are no shipwright-build/ or shared-resource/ subdirectories

The other components also does the same, so I was assuming manifests are pulled in during the test workflow runtime. Is there anything like that?

jkhelil · 2026-11-02T08:37:14Z

Please

Add a unit test in pkg/reconciler/shared/tektonconfig/sharedresource/ verifying that an existing TektonConfig with no platforms.openshift.sharedResource field does NOT trigger SharedResource installation after upgrade."
there is a kind of asymetrie in defaults

type ShipwrightBuildConfig struct {
    // +kubebuilder:default=false
    Enabled bool `json:"enabled"`
}

// sharedresource_types.go
type SharedResourceConfig struct {
// +kubebuilder:default=true
Enabled bool json:"enabled"
}
if any code path ever auto-populates platforms.openshift.sharedResource: {} in TektonConfig (e.g., a defaulting webhook in the future, or a controller patching the spec), SharedResource gets installed silently.

We need to turn also shareresource default to false

Do an upgrade manual testing on operator (first make apply then change version in two places in config/kubernetes/base/operator.yaml and apply again

waveywaves · 2026-11-04T15:09:08Z

+	sr.Status.MarkPreReconcilerComplete()
+
+	// Create Main InstallerSet
+	if err := r.installerSetClient.MainSet(ctx, sr, r.releaseManifest, FilterAndTransform(r)); err != nil {


For a standalone CR, should enabled: false disable the component, or is deleting the CR the intended way to remove it? Both SharedResource and ShipwrightBuild currently ignore this flag, while their docs say setting it to false removes the component.

I don't see the other controllers using this property either. It's better to remove it from the Docs. Considering this would need sync the property from TektonConfig property and this CR's for edge cases.

waveywaves · 2026-11-04T15:09:09Z

        args:
        - "-controllers"
-        - "tektonconfig,tektonpipeline,tektontrigger,tektonchain,tektonresult,tektondashboard,manualapprovalgate,tektonpruner,tektonkueue,tektonmulticlusterproxyaae,openshiftpipelinesascode"
+        - "tektonconfig,tektonpipeline,tektontrigger,tektonchain,tektonresult,tektondashboard,manualapprovalgate,tektonpruner,tektonkueue,tektonmulticlusterproxyaae,openshiftpipelinesascode,shipwrightbuild"


Are Helm installations meant to support these components as part of this PR? New CRDs are being added to the chart, but its controller lists and operator roles are still missing the corresponding entries. If Helm support is included, those need updating too.

For kubernetes, only shipwrightbuild controller will be supported.
the roles includes "roles.yaml" under base and in openshift includes "shipwright.io" group.
Is there any other places they needs to be included?

waveywaves · 2026-11-04T15:09:09Z

+		transformers = append(transformers,
+			openshiftcommon.AnnotateMetricsServingCert(shipwrightbuild.ControllerDeploymentName),
+			openshiftcommon.RenameServicePort(shipwrightbuild.ControllerDeploymentName, openshiftcommon.MetricsHTTPPort, openshiftcommon.MetricsHTTPSPort),
+			openshiftcommon.ApplyMetricsTLS(common.KindDeployment, shipwrightbuild.ControllerDeploymentName,


Where is shipwright-build-controller-metrics-tls expected to be created? This mounts it as a required Secret, but the certificate annotation targets a shipwright-build-controller Service that is not in the bundled release. Without that Secret, a fresh controller Pod cannot start when metrics mTLS is enabled.

Created an issue upstream to include the service in the release manifests.
shipwright-io/build#2411

I'll comment out the metric tls for now.

… component Changes: Adds two new operator-managed components: ShipwrightBuild and SharedResource. New CRDs & API types — ShipwrightBuild and SharedResource added to pkg/apis/operator/v1alpha1/ (types, defaults, lifecycle, validation), registered in the scheme (register.go) with resource-name constants and the one-CR-per-type Validate() check. ShipwrightBuild component — Kubernetes reconciler + transformer and an OpenShift extension/controller, wired through TektonConfig on both platforms. Installs the Shipwright Build controller. SharedResource component — OpenShift-only reconciler, extension, controller, and transformer, plus NetworkPolicies and service-CA handling. OpenShift service-CA helper — new pkg/reconciler/openshift/common/serviceca.go for injecting the service CA bundle. Platform wiring — registered both components in TektonConfig extensions (Kubernetes & OpenShift), platform constants, the webhook, and the shared/init controllers. TektonInstallerSet DaemonSet support — adds a DaemonSet installer to the InstallerSet reconcile flow and client (new DaemonSetReady condition), mirroring the StatefulSet handling for apply, readiness wait, and cleanup, so components can ship DaemonSet workloads. RBAC / config — updates to config/base/role.yaml, kustomization, and operator manifests. Tests — unit tests for reconcilers, transformers, validation, lifecycle, NetworkPolicies, service-CA, and the DaemonSet installer; e2e tests and test/resources / test/utils helpers for both new components. Installs cert-manager on Kubernetes (skipped on OpenShift) on E2E workflow, so the ShipwrightBuild webhook certificate can be provisioned. Signed-off-by: Sayan Biswas <sabiswas@redhat.com>

pratap0007 · 2026-11-05T04:37:38Z

 | `catalog-{INDEX}-url` | URL endpoint of the hub API | Yes |
-
-`catalog-{INDEX}-type` and `hub-catalog-type` were removed in Pipelines as Code 0.51.0. On upgrade, the operator deletes `hub-catalog-type` from TektonConfig, the OpenShiftPipelinesAsCode CR, and the `pipelines-as-code` ConfigMap.
+| `catalog-{INDEX}-type` | Type of hub: `artifacthub` (for Artifact Hub) or `tektonhub` (for Tekton Hub) | Yes |


is this change required for the Shipwright component ?

pratap0007 · 2026-11-05T06:18:27Z

+
+		metrics, err := common.NoMetrics()
+		if err != nil {
+			logger.Errorf("Failed to create trigger metrics recorder %v", err)


Suggested change

logger.Errorf("Failed to create trigger metrics recorder %v", err)

logger.Errorf("Failed to create shipwrightbuild metrics recorder %v", err)

pratap0007 · 2026-11-05T07:26:47Z

 	}

+	// On TektonConfig teardown, remove the shipwright-build CRs it owns.
+	if err := shipwrightbuild.DeleteIfExists(ctx, oe.operatorClientSet.OperatorV1alpha1().ShipwrightBuilds()); err != nil {


why do we want to remove shipwright-build CR?

tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 21, 2026

tekton-robot requested review from infernus01 and pratap0007 September 21, 2026 13:06

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 21, 2026

sayan-biswas mentioned this pull request Sep 21, 2026

ADR-0004: Integrate OpenShift Builds in OpenShift Pipelines openshift-pipelines/architecture#4

Open

4 of 7 tasks

jkhelil reviewed Sep 22, 2026

View reviewed changes

psrvere reviewed Sep 30, 2026

View reviewed changes

Comment thread pkg/reconciler/kubernetes/kubernetesplatform/config.go Resolved

psrvere reviewed Sep 30, 2026

View reviewed changes

Comment thread pkg/reconciler/kubernetes/shipwrightbuild/reconciler.go Resolved

psrvere reviewed Sep 30, 2026

View reviewed changes

Comment thread pkg/reconciler/kubernetes/shipwrightbuild/common.go Resolved

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2026

sayan-biswas changed the title ~~WIP(openshift builds extension): add Shipwright Build and Shared Res…~~ WIP: Add Shipwright Build and Shared Resource extension Oct 13, 2026

sayan-biswas force-pushed the builds-extension branch from 7191617 to 7b1fd61 Compare October 19, 2026 11:06

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2026

sayan-biswas force-pushed the builds-extension branch from 7b1fd61 to 53a146f Compare October 19, 2026 11:11

sayan-biswas marked this pull request as ready for review October 19, 2026 11:11

tekton-robot requested review from jkhelil and khrm October 19, 2026 11:11

sayan-biswas changed the title ~~WIP: Add Shipwright Build and Shared Resource extension~~ Add Shipwright Build and Shared Resource extension Oct 21, 2026

tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 21, 2026

jkhelil reviewed Oct 26, 2026

View reviewed changes

jkhelil requested changes Oct 26, 2026

View reviewed changes

sayan-biswas force-pushed the builds-extension branch from 53a146f to fab1478 Compare October 27, 2026 07:57

tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 27, 2026

sayan-biswas force-pushed the builds-extension branch from fab1478 to 3778b78 Compare October 28, 2026 08:04

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2026

sayan-biswas force-pushed the builds-extension branch from 3778b78 to b48a54f Compare October 29, 2026 00:34

avinal reviewed Oct 30, 2026

View reviewed changes

Comment thread hack/fetch-releases.sh Resolved

sayan-biswas force-pushed the builds-extension branch 2 times, most recently from cf11817 to 811de00 Compare November 1, 2026 22:18

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Nov 1, 2026

sayan-biswas force-pushed the builds-extension branch from 811de00 to fccf62c Compare November 2, 2026 04:19

sayan-biswas requested a review from jkhelil November 2, 2026 06:15

jkhelil requested a balanced review from Copilot November 2, 2026 07:55

Copilot started reviewing on behalf of jkhelil November 2, 2026 07:55

View session

Copilot AI reviewed Nov 2, 2026

View reviewed changes

jkhelil requested changes Nov 2, 2026

View reviewed changes

avinal mentioned this pull request Nov 3, 2026

feat: Conditional installation and migration of openshift builds #4378

Draft

3 of 4 tasks

sayan-biswas force-pushed the builds-extension branch 3 times, most recently from 0de4233 to 13c5345 Compare November 3, 2026 22:26

sayan-biswas requested a review from jkhelil November 3, 2026 22:26

sayan-biswas force-pushed the builds-extension branch from 13c5345 to a3b3cbc Compare November 4, 2026 00:37

waveywaves reviewed Nov 4, 2026

View reviewed changes

sayan-biswas force-pushed the builds-extension branch from a3b3cbc to 3ab2bdc Compare November 5, 2026 02:21

pratap0007 reviewed Nov 5, 2026

View reviewed changes

	logger.Errorf("Failed to create trigger metrics recorder %v", err)
	logger.Errorf("Failed to create shipwrightbuild metrics recorder %v", err)

Conversation

sayan-biswas commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Sep 21, 2026

Uh oh!

codecov Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkhelil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkhelil commented Oct 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sayan-biswas commented Nov 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkhelil commented Nov 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sayan-biswas commented Sep 21, 2026 •

edited

Loading

codecov Bot commented Sep 21, 2026 •

edited

Loading