Drop explicit envvar handling from reportportal keys#4978
Draft
happz wants to merge 1 commit into
Draft
Conversation
tmt should be now fully capable of extracting and delivering values to keys of plugins that are not mentioned on command line. The very special magic performed by plugins to get their keys populated via envvars should not longer be needed.
happz
added
plugin | reportportal
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors ReportReportPortalData in tmt/steps/report/reportportal.py by removing custom environment variable helper functions and replacing them with static default values. The artifacts_url field now uses the envvar parameter directly, and upload_log_pattern is simplified to use DEFAULT_LOG_PATTERNS.copy. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
LecrisUT
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tmt should be now fully capable of extracting and delivering values to keys of plugins that are not mentioned on command line. The very special magic performed by plugins to get their keys populated via envvars should no longer be needed.
Pull Request Checklist