Handle top-level file changes more properly in modified-ref#4927
Open
LecrisUT wants to merge 1 commit into
Open
Handle top-level file changes more properly in modified-ref#4927LecrisUT wants to merge 1 commit into
modified-ref#4927LecrisUT wants to merge 1 commit into
Conversation
Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
added
the
ci | full test
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the discovery step in tmt/steps/discover/fmf.py to handle top-level directory changes. Specifically, it introduces a special case for the top-level directory (Path(".")) to prevent matching literal /\. and instead matches ^/. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was trying to run the test
/\.because the path parent was expanded asPath('.').Fixes #4610
Pull Request Checklist