Mock provision: make detection of finished processes more deterministic by mkoncek · Pull Request #4437 · teemtee/tmt

mkoncek · 2025-12-17T13:21:19Z

Based on: #4173
I found out that various environments (fedora-rawhide-x86_64) print different number of empty strings on their stdout as the commands spawned in the chroots finish. This causes some environments to hang.
This PR makes the detection more deterministic.

Pull Request Checklist

mkoncek · 2026-01-21T09:48:49Z

@happz Rebased on the current HEAD.

mkoncek · 2026-02-23T12:40:30Z

The primary cause of this bug was the assumption that each finished command prints a single newline on stdout after it is finished. This turned out not to be true in some environments. So we print a binary zero after the initial commands are finished and then loop until we read that binary zero back.

Later the command completion is detected by returncode being written into its pre-determined file, instead of waiting on a newline on stdout again.

mkoncek · 2026-02-23T13:34:29Z

Also:

        self.mock_shell.stdin.write(''.join(command + '\n' for command in commands))
        # Issue a command writing a binary zero on the standard output after all
        # the previous commands are finished.
        self.mock_shell.stdin.write('echo -e \\\\x00\n')

could be rewritten as:

        self.mock_shell.stdin.write('\n'.join(commands))
        # Issue a command writing a binary zero on the standard output after all
        # the previous commands are finished.
        self.mock_shell.stdin.write('\necho -e \\\\x00\n')

And then we could use a different string to mark the end of commands.

Afaik in that initialization we only execute things like rm, mkdir, mkfifo and such so there are no arbitrary strings written to stdout.

mkoncek · 2026-02-26T09:41:15Z

@LecrisUT I went over your concerns and tried to apply fixes.

LecrisUT

Looks good enough for me. Could you rebase please?

Unrelated, but can you also open a PR to revert and give more context on what needs to be done?

tmt/tests/prepare/shell/main.fmf

Lines 9 to 11 in 644c58c

    
           # TODO Disable for now under the mock provision plan because of 
        
           # https://bugzilla.redhat.com/show_bug.cgi?id=2415701 
        
           #- provision-mock

Would prefer to be explicit on the AVC checks that are skipped, but when I tried to revert that, it seemed to have some more genuine errors in it.

thrix · 2026-03-15T20:29:05Z

Looks good enough for me. Could you rebase please?

I rebased it.

thrix

Code Review: Mock provision — make detection of finished processes more deterministic

Reviewed against commit 3f5cf6d.

Summary

The PR fixes a real bug where mock shell environments produce varying numbers of spurious newlines on stdout, causing the previous counting-based completion detection to hang. The fix introduces two improvements:

In _simple_execute: uses a sentinel keyword (TMT_FINISHED_EXEC) echoed to stdout instead of counting newlines
In _spawn_command: uses the returncode file fd instead of mock shell stdout for completion detection

The overall approach is sound and addresses the root cause well. However, there's a bug in the sentinel detection that could cause the same hanging behavior.

Issues

1. _simple_execute sentinel comparison is fragile — potential hang (bug)

The sentinel check uses exact == equality on self.mock_shell.stdout.read(). Since stdout is a non-blocking TextIOWrapper, read() returns all currently available data. If spurious newlines and the sentinel arrive in the same pipe buffer (very likely since all commands are fast and flushed at once), read() returns e.g. '\n\n\n\nTMT_FINISHED_EXEC\n' which does NOT equal 'TMT_FINISHED_EXEC\n'. The loop hangs.

Verified with a Python test demonstrating the behavior. Fix: use endswith() instead of ==. See inline comment.

2. Stale comment (minor)

"Wait until we read the binary zero from stdout" refers to a previous implementation. Should say "finished keyword" or "sentinel". See inline comment.

Observations

3. _spawn_command: returncode_fd not in the event loop

When returncode_fd has data alongside other events, the data is left unread until it becomes the sole event. Works in practice but is less responsive than the old code. See inline comment.

Verdict

The approach is correct and a clear improvement over counting newlines. Issue #1 (fragile == comparison) must be fixed before merging — it could reproduce the exact hang this PR aims to solve.

Generated-by: Claude Code

LecrisUT · 2026-03-27T09:52:03Z

Btw, you are missing

require+:
  - tmt+provision-mock

in /test/provision/mock/main.fmf

mkoncek · 2026-03-27T10:00:41Z

Interesting.
Mock plugin does nothing with sudo.
Maybe I could try raising the priority of the mock package managers over bootc?
I will also add the FMF field.

LecrisUT · 2026-03-27T10:09:38Z

Maybe I could try raising the priority of the mock package managers over bootc?

It's not the bootc specifically, it's somewhere in all of the _query commands, facts.sudo_prefix, guest.become etc. logic. It is a bit hard to tell and I suspect the stdout/stderr are coming out-of-order as well

LecrisUT · 2026-03-27T10:14:11Z

More specifically, here is where the stdout/stderr started to diverge

tmt/tmt/guest/__init__.py

Lines 907 to 915 in 6fa1983

    
           def _query_sudo_prefix(self, guest: 'Guest') -> str: 
        
               # Note: we cannot reuse `is_superuser` or `can_sudo` fact so we just recall the query 
        
               # functions for now 
        
               if self._query_is_superuser(guest): 
        
                   # Root user does not need sudo 
        
                   return "" 
        
               if self._query_can_sudo(guest): 
        
                   return "sudo" 
        
               return ""

        cmd: whoami
        stdout: root
        cmd: sudo -n true
        cmd: whoami
        stderr: sh: sudo: command not found
        cmd: sudo -n true
        stdout: root

mkoncek · 2026-03-27T13:23:24Z

Thank you for the debugging, it seems difficult to find cause...

thrix · 2026-03-31T11:09:38Z

testing-farm reserve --compose Fedora-44
(update tmt from the copr repository on the machine)
(logout)
testing-farm list --reservations
tmt run -a provision -h connect -g <IP_FROM_ABOVE> plan --name .... test --name ...

LecrisUT · 2026-04-02T09:25:18Z

Thank you for the debugging, it seems difficult to find cause...

So the sudo part seems to be a red-herring because in another test, I saw it starting to diverge at a later point

        cmd: /bin/bash -c '[ -e /run/.toolboxenv ] && echo yes || echo no'
        stdout: no
        cmd: /bin/bash -c '[ -e /run/.containerenv ] && echo yes || echo no'
        cmd: /bin/bash -c 'echo -n "$container"'
        stdout: no
        cmd: /bin/bash -c '[ -d /usr/local/bin ] ||  mkdir -p /usr/local/bin'

It seems to me that there is something funky with the implementation. Something about missing read/writes to the epoll causing it to hang or skip some outputs.

At least I can confirm that @thrix's suggestion does help you reproduce it. You can add a login -t to it to get the shell after the test execution, although if the test is causing it to stall, then you have a long time to wait

mkoncek · 2026-04-02T10:44:36Z

From traceback, first the traceback, the the cmd: ... output:

  File "/usr/lib64/python3.14/threading.py", line 1044, in _bootstrap
    self._bootstrap_inner()
  File "/usr/lib64/python3.14/threading.py", line 1082, in _bootstrap_inner
    self._context.run(self.run)
  File "/usr/lib64/python3.14/threading.py", line 1024, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 119, in _worker
    work_item.run(ctx)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 86, in run
    result = ctx.run(self.task)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 73, in run
    return fn(*args, **kwargs)
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 887, in go
    self._guest.setup()
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1949, in setup
    self.install_scripts(tmt.steps.scripts.SCRIPTS)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1902, in install_scripts
    f"[ -d {quote(str(self.scripts_path))} ] || "
  File "/usr/lib64/python3.14/functools.py", line 1126, in __get__
    val = self.func(instance)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1822, in scripts_path
    if self.facts.is_ostree
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1978, in facts
    facts.sync(self)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1052, in sync
    self.is_superuser = self._query_is_superuser(guest)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 891, in _query_is_superuser
    output = self._execute(guest, Command('whoami'))
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 654, in _execute
    return guest.execute(command, silent=True)
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 624, in execute
    *self.mock_shell.execute(
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 504, in execute
    traceback.print_stack()
        cmd: whoami
        stdout: root
  File "/usr/lib64/python3.14/threading.py", line 1044, in _bootstrap
    self._bootstrap_inner()
  File "/usr/lib64/python3.14/threading.py", line 1082, in _bootstrap_inner
    self._context.run(self.run)
  File "/usr/lib64/python3.14/threading.py", line 1024, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 119, in _worker
    work_item.run(ctx)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 86, in run
    result = ctx.run(self.task)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 73, in run
    return fn(*args, **kwargs)
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 887, in go
    self._guest.setup()
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1949, in setup
    self.install_scripts(tmt.steps.scripts.SCRIPTS)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1902, in install_scripts
    f"[ -d {quote(str(self.scripts_path))} ] || "
  File "/usr/lib64/python3.14/functools.py", line 1126, in __get__
    val = self.func(instance)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1822, in scripts_path
    if self.facts.is_ostree
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1978, in facts
    facts.sync(self)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1053, in sync
    self.can_sudo = self._query_can_sudo(guest)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 900, in _query_can_sudo
    guest.execute(Command("sudo", "-n", "true"), silent=True)
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 624, in execute
    *self.mock_shell.execute(
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 504, in execute
    traceback.print_stack()
        cmd: sudo -n true
        stderr: sh: sudo: command not found
  File "/usr/lib64/python3.14/threading.py", line 1044, in _bootstrap
    self._bootstrap_inner()
  File "/usr/lib64/python3.14/threading.py", line 1082, in _bootstrap_inner
    self._context.run(self.run)
  File "/usr/lib64/python3.14/threading.py", line 1024, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 119, in _worker
    work_item.run(ctx)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 86, in run
    result = ctx.run(self.task)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 73, in run
    return fn(*args, **kwargs)
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 887, in go
    self._guest.setup()
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1949, in setup
    self.install_scripts(tmt.steps.scripts.SCRIPTS)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1902, in install_scripts
    f"[ -d {quote(str(self.scripts_path))} ] || "
  File "/usr/lib64/python3.14/functools.py", line 1126, in __get__
    val = self.func(instance)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1822, in scripts_path
    if self.facts.is_ostree
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1978, in facts
    facts.sync(self)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1054, in sync
    self.sudo_prefix = self._query_sudo_prefix(guest)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 910, in _query_sudo_prefix
    if self._query_is_superuser(guest):
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 891, in _query_is_superuser
    output = self._execute(guest, Command('whoami'))
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 654, in _execute
    return guest.execute(command, silent=True)
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 624, in execute
    *self.mock_shell.execute(
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 504, in execute
    traceback.print_stack()
        cmd: whoami
        stdout: root
  File "/usr/lib64/python3.14/threading.py", line 1044, in _bootstrap
    self._bootstrap_inner()
  File "/usr/lib64/python3.14/threading.py", line 1082, in _bootstrap_inner
    self._context.run(self.run)
  File "/usr/lib64/python3.14/threading.py", line 1024, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 119, in _worker
    work_item.run(ctx)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 86, in run
    result = ctx.run(self.task)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 73, in run
    return fn(*args, **kwargs)
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 887, in go
    self._guest.setup()
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1949, in setup
    self.install_scripts(tmt.steps.scripts.SCRIPTS)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1902, in install_scripts
    f"[ -d {quote(str(self.scripts_path))} ] || "
  File "/usr/lib64/python3.14/functools.py", line 1126, in __get__
    val = self.func(instance)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1822, in scripts_path
    if self.facts.is_ostree
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1978, in facts
    facts.sync(self)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1055, in sync
    self.is_ostree = self._query_is_ostree(guest)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 919, in _query_is_ostree
    output = self._execute(
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 654, in _execute
    return guest.execute(command, silent=True)
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 624, in execute
    *self.mock_shell.execute(
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 504, in execute
    traceback.print_stack()
        cmd:
            /bin/bash -c '
            ( [ -e /run/ostree-booted ] || [ -L /ostree ] ) && echo yes || echo no
            '
        stdout: no
  File "/usr/lib64/python3.14/threading.py", line 1044, in _bootstrap
    self._bootstrap_inner()
  File "/usr/lib64/python3.14/threading.py", line 1082, in _bootstrap_inner
    self._context.run(self.run)
  File "/usr/lib64/python3.14/threading.py", line 1024, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 119, in _worker
    work_item.run(ctx)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 86, in run
    result = ctx.run(self.task)
  File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 73, in run
    return fn(*args, **kwargs)
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 887, in go
    self._guest.setup()
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1949, in setup
    self.install_scripts(tmt.steps.scripts.SCRIPTS)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1902, in install_scripts
    f"[ -d {quote(str(self.scripts_path))} ] || "
  File "/usr/lib64/python3.14/functools.py", line 1126, in __get__
    val = self.func(instance)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1822, in scripts_path
    if self.facts.is_ostree
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1978, in facts
    facts.sync(self)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 1056, in sync
    self.is_image_mode = self._query_is_image_mode(guest)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 944, in _query_is_image_mode
    sudo_prefix = self._query_sudo_prefix(guest)
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 910, in _query_sudo_prefix
    if self._query_is_superuser(guest):
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 891, in _query_is_superuser
    output = self._execute(guest, Command('whoami'))
  File "/home/mkoncek/Upstream/tmt/tmt/guest/__init__.py", line 654, in _execute
    return guest.execute(command, silent=True)
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 624, in execute
    *self.mock_shell.execute(
  File "/home/mkoncek/Upstream/tmt/tmt/steps/provision/mock.py", line 504, in execute
    traceback.print_stack()
        cmd: whoami
        stdout: root

It seems like the multiple invocations of whoami and sudo -n true are done by tmt, and not a mishandled output.

LecrisUT · 2026-04-02T12:07:56Z

It seems like the multiple invocations of whoami and sudo -n true are done by tmt, and not a mishandled output.

Yes, the fact that some commands are done multiple times is not the issue. The issue seems to be with the out-of-order handling of stdout. It's like one of the stdout read was completely skipped and delayed for the next cmd execution. Maybe the following is also valuable from the centos-stream-9 logs

        cmd: /bin/bash -c '[ -d /usr/local/bin ] || sudo mkdir -p /usr/local/bin'
        fail:
            Invalid state when executing command 'tar -C /usr/local/bin -xf /srv/tmt-mock/filesync --exclude=/tmp/tmp.5rdImvI8F4/scripts/tmt.sh 1>/srv/tmt-mock/stdout 2>/srv/tmt-mock/stderr ; echo $?>/srv/tmt-mock/returncode
            '.
        mock: Exiting shell...
        mock: Exited shell.

    Cause number 1:

        Invalid state when executing command 'tar -C /usr/local/bin -xf /srv/tmt-mock/filesync --exclude=/tmp/tmp.5rdImvI8F4/scripts/tmt.sh 1>/srv/tmt-mock/stdout 2>/srv/tmt-mock/stderr ; echo $?>/srv/tmt-mock/returncode
        '.


            Traceback (most recent call last):

            File /usr/lib/python3.9/site-packages/tmt/queue.py, line 91, in _extract_task_outcome
              task.result = extract(*args, **kwargs)


            File /usr/lib64/python3.9/concurrent/futures/_base.py, line 439, in result
              return self.__get_result()


            File /usr/lib64/python3.9/concurrent/futures/_base.py, line 391, in __get_result
              raise self._exception


            File /usr/lib64/python3.9/concurrent/futures/thread.py, line 58, in run
              result = self.fn(*self.args, **self.kwargs)


            File /usr/lib/python3.9/site-packages/tmt/steps/provision/mock.py, line 881, in go
              self._guest.setup()


            File /usr/lib/python3.9/site-packages/tmt/guest/__init__.py, line 1949, in setup
              self.install_scripts(tmt.steps.scripts.SCRIPTS)


            File /usr/lib/python3.9/site-packages/tmt/guest/__init__.py, line 1930, in install_scripts
              self.push(


            File /usr/lib/python3.9/site-packages/tmt/steps/provision/mock.py, line 721, in push
              next(p)


            File /usr/lib/python3.9/site-packages/tmt/steps/provision/mock.py, line 480, in _spawn_command
              raise tmt.utils.RunError(

tcornell-bus · 2026-05-14T17:12:33Z

/packit build

… read

mkoncek · 2026-06-09T13:55:48Z

I applied one more change as suggested by @tcornell-bus, which hopefully would fix the the failing test.

mkoncek added bug Something isn't working step | provision Stuff related to the provision step plugin | mock Related to mock provision plugin labels Dec 17, 2025

happz added the ci | full test Pull request is ready for the full test execution label Jan 7, 2026

happz added this to planning Jan 7, 2026

github-project-automation Bot moved this to backlog in planning Jan 7, 2026

happz moved this from backlog to review in planning Jan 7, 2026

happz added the status | blocked The merging of PR is blocked on some other issue label Jan 7, 2026

mkoncek force-pushed the mock-process-fix branch from fdead6f to 702c1c4 Compare January 21, 2026 09:08

mkoncek force-pushed the mock-process-fix branch from 702c1c4 to c640c33 Compare February 23, 2026 12:24

LecrisUT reviewed Feb 23, 2026

View reviewed changes

Comment thread tmt/steps/provision/mock.py Outdated

mkoncek force-pushed the mock-process-fix branch from c640c33 to 6604f03 Compare February 23, 2026 12:37

graphite-app Bot reviewed Feb 23, 2026

View reviewed changes

Comment thread tmt/steps/provision/mock.py

LecrisUT reviewed Feb 23, 2026

View reviewed changes

Comment thread tmt/steps/provision/mock.py Outdated

Comment thread tmt/steps/provision/mock.py Outdated

LecrisUT removed the status | blocked The merging of PR is blocked on some other issue label Feb 23, 2026

LecrisUT reviewed Feb 23, 2026

View reviewed changes

Comment thread tmt/steps/provision/mock.py Outdated

LecrisUT assigned LecrisUT and happz Mar 12, 2026

LecrisUT approved these changes Mar 13, 2026

View reviewed changes

LecrisUT removed their assignment Mar 13, 2026

thrix force-pushed the mock-process-fix branch from 8a7c7df to 3f5cf6d Compare March 15, 2026 20:28

thrix requested changes Mar 15, 2026

View reviewed changes

Comment thread tmt/steps/provision/mock.py Outdated

Comment thread tmt/steps/provision/mock.py

Comment thread tmt/steps/provision/mock.py

psss added this to the 1.70 milestone Mar 16, 2026

graphite-app Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread tmt/steps/provision/mock.py Outdated

This comment was marked as resolved.

Sign in to view

mkoncek force-pushed the mock-process-fix branch from 991b595 to ad0bd1f Compare March 27, 2026 10:04

thrix assigned LecrisUT Mar 30, 2026

thrix moved this from review to implement in planning Apr 8, 2026

thrix modified the milestones: 1.71, 1.72 Apr 9, 2026

happz removed this from the 1.71 milestone Apr 9, 2026

tcornell-bus self-assigned this Apr 30, 2026

mkoncek added 9 commits June 9, 2026 15:53

mock provision: make detection of finished processes more deterministic

d312b6d

mock provision: Refactor

6887757

mock provision: Make command finish detection more reliable

c50c5e3

mock provision: Improve code-level documentation

b78d7f3

mock provision: Improve mock shell missing returncode handling

3bad1c7

mock provision: Implement delete option on file push

891e686

mock provision: Add tmt-mock test requirement

9574038

mock provision: Raise mock package manager probe priority over bootc

5b4cff8

mock provision: Keep polling for returncode_fd until an exit value is…

ed49426

… read

mkoncek force-pushed the mock-process-fix branch from ad0bd1f to ed49426 Compare June 9, 2026 13:54

	# TODO Disable for now under the mock provision plan because of
	# https://bugzilla.redhat.com/show_bug.cgi?id=2415701
	#- provision-mock

Conversation

mkoncek commented Dec 17, 2025

Uh oh!

mkoncek commented Jan 21, 2026

Uh oh!

Uh oh!

mkoncek commented Feb 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkoncek commented Feb 23, 2026

Uh oh!

Uh oh!

mkoncek commented Feb 26, 2026

Uh oh!

LecrisUT left a comment

Choose a reason for hiding this comment

Uh oh!

thrix commented Mar 15, 2026

Uh oh!

thrix left a comment

Choose a reason for hiding this comment

Code Review: Mock provision — make detection of finished processes more deterministic

Summary

Issues

Observations

Verdict

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

LecrisUT commented Mar 27, 2026

Uh oh!

mkoncek commented Mar 27, 2026

Uh oh!

LecrisUT commented Mar 27, 2026

Uh oh!

LecrisUT commented Mar 27, 2026

Uh oh!

mkoncek commented Mar 27, 2026

Uh oh!

thrix commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LecrisUT commented Apr 2, 2026

Uh oh!

mkoncek commented Apr 2, 2026

Uh oh!

LecrisUT commented Apr 2, 2026

Uh oh!

tcornell-bus commented May 14, 2026

Uh oh!

mkoncek commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

thrix commented Mar 31, 2026 •

edited

Loading