Conversation
gibson042
force-pushed
the
2026-08-define-typedarray-tolocalestring
branch
2 times, most recently
from
August 24, 2026 17:04
d379b1b to
1196898
Compare
gibson042
added
web reality
s: discuss
sffc
approved these changes
Sep 17, 2026
| 1. Set _result_ to the string-concatenation of _result_ and _elementString_. | ||
| 1. Set _k_ to _k_ + 1. | ||
| 1. Return _result_. | ||
| 1. Return ? JoinIndexedProperties(_array_, _length_, ~auto~, *"toLocaleString"*, « _locales_, _options_ »). |
Contributor
There was a problem hiding this comment.
It seems like we should pass _separator_ in here instead of relying on 262 to have the ILD behavior
Member
Author
There was a problem hiding this comment.
Updated to pass it explicitly, but using an operation defined in ECMA-262.
sffc
moved this from Priority Issues
to Previously Discussed
in ECMA-402 Meeting Topics
gibson042
force-pushed
the
2026-08-define-typedarray-tolocalestring
branch
from
September 17, 2026 18:36
1196898 to
382e8eb
Compare
Depends upon JoinIndexedElements from tc39/ecma262#3958
gibson042
force-pushed
the
2026-08-define-typedarray-tolocalestring
branch
from
September 17, 2026 19:31
382e8eb to
7c6de7d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1094
Depends upon JoinIndexedProperties and LocalizedListSeparator from tc39/ecma262#3958