Repository navigation
perf(sync): request an empty RDB when sync_rdb is disabled - #1076
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
sync_reader.sync_rdb=false, the source still serializes and transfers its complete dataset before RedisShake discards the RDB. This makes starting incremental-only synchronization unnecessarily expensive for large datasets.Negotiate EOF capability and request
REPLCONF rdb-filter-only ""before PSYNC when RDB synchronization is disabled. Supporting sources send an empty RDB; server-side rejection falls back to receiving and discarding the full snapshot. Connection failures and invalid replies still fail the handshake. EOF is negotiated automatically for this mode, including with the defaulttry_diskless=false.Also acknowledge replication offset zero after receiving the RDB. A newly created backlog can start at zero, and an EOF-based source waits for that ACK before releasing the incremental stream. The source still forks and sends an empty RDB; the PSYNC starting-point semantics are unchanged.
Validation:
go test ./... -count=1go test -race ./internal/reader -run TestSyncReader -count=1repl-diskless-sync=no/yesandtry_diskless=false. They verify that existing keys are skipped and subsequent writes reach the target.Includes configuration comments and English/Chinese documentation for capability negotiation, fallback, and the remaining fork/RDB overhead.