Repository navigation
device: make peer queue sizing explicit and independent of global - #100
Merged
Merged
Conversation
creachadair
approved these changes
Sep 25, 2026
jwhited
reviewed
Sep 28, 2026
jwhited
approved these changes
Sep 28, 2026
jwhited
left a comment
jwhited
left a comment
Member
There was a problem hiding this comment.
Commit needs a github issue. Just docs nits. LGTM.
illotum
force-pushed
the
illotum/peer-queue-size
branch
from
September 28, 2026 21:42
9ad5331 to
68c32a0
Compare
Unlike TUN, the Bind provides no easy scaling factor for the device-wide inbound queue. Size the device-wide queues from their own values and let the caller state the scaling it wants. WithQueueOutboundSize and WithQueueInboundSize now set the device-wide queue and, unless overridden, the matching per-peer queue. WithPeerQueueOutboundSize and WithPeerQueueInboundSize override the per-peer queues regardless of the order options are given in. Updates: tailscale/corp#48168 Signed-off-by: Alex Valiushko <alexvaliushko@tailscale.com> Change-Id: Iaa0a1a12e940ddf4f5ca44ade86417df6a6a6964
illotum
force-pushed
the
illotum/peer-queue-size
branch
from
September 28, 2026 21:48
68c32a0 to
d69891b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike TUN, the Bind provides no easy scaling factor for the device-wide inbound queue. Size the device-wide queues from their own values and let the caller state the scaling it wants.
WithQueueOutboundSize and WithQueueInboundSize now set the device-wide queue and, unless overridden, the matching per-peer queue. WithPeerQueueOutboundSize and WithPeerQueueInboundSize override the per-peer queues regardless of the order options are given in.
Updates: tailscale/corp#48168