Repository navigation
fix(cute): use assertion failure handler on device - #32
Merged
Merged
Conversation
Use __assert_fail for device failures while preserving the original host assertion and printing behavior.
There was a problem hiding this comment.
🔵 Needs a closer look
The unavailable SDK implementation of __assert_fail leaves it unverified whether replacing unconditional __brkpt() preserves execution interruption on PPU 1.5 under -DNDEBUG, including RTC compilation.
No open issues 🎉
What changed in this PR
Updates CUTE’s device-side invalid-control-path handling to call __assert_fail directly, addressing assertion handling under NDEBUG while preserving host behavior.
Changes:
- Replaces the device-side assert, print, and breakpoint sequence with the assertion failure handler.
- Passes the diagnostic message, file, line, and function to the handler.
| File | Description |
|---|---|
include/cute/config.hpp |
Updates the device-side CUTE_INVALID_CONTROL_PATH macro; leaves the host branch unchanged. |
Review effort: Balanced
Yongheng-Cao
approved these changes
Nov 2, 2026
hemengchi
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Related Issue
Closes #30
Change Type
Validation
Risks and Compatibility