test: fix failure when run with SSH_AUTH_SOCK#59
Open
mvo5 wants to merge 1 commit into
Open
Conversation
The tests will hang currently when run on a developer desktop and there is a `SSH_AUTH_SOCK` env set. Because the code will try to construct an sshauth header when it finds ssh credentials it will use this env even when the tests are not meant to use the sshauth path. This commit fixes this by unseting SSH_AUTH_SOCK during the tests. While doing this a test-helper got extracted to remove some of the duplication we had before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests will hang currently when run on a developer desktop and there is a
SSH_AUTH_SOCKenv set. Because the code will try to construct an sshauth header when it finds ssh credentials it will use this env even when the tests are not meant to use the sshauth path. This commit fixes this by unseting SSH_AUTH_SOCK during the tests.While doing this a test-helper got extracted to remove some of the duplication we had before.