fix(torch): preserve state dtype on reset - #32
Open
Missing-Identity wants to merge 1 commit into
Open
Conversation
Member
|
Dear @Missing-Identity , Thank you so much for opening a PR! Please send an email to Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #31 by preserving the live tensor dtype when
TorchModule.reset_state()regenerates a Torch-backed state value.LIFTorch.to(torch.float64)followed byreset_state().Validation
pytest -q tests/tests_default/test_lif_torch.py— 15 passed, 1 skippedpytest -q tests/tests_default/test_torch_module.py— 7 passedblack==22.3.0 --check rockpool/nn/modules/torch/torch_module.py tests/tests_default/test_lif_torch.pygit diff --checkScope note
The current upstream
LIFTorchfloat64 forward path also fails without a reset because its spike-generation implementation emits float32. This PR intentionally fixes only the reset-state dtype regression reported in #31; the broader forward-path issue is separate from this minimal change.