fix: backport upstream electrum sync fix (PR #4341) #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Release
|
ovitrif
changed the title
ben-kaufman
approved these changes
Jan 26, 2026
Author
|
Going to merge after I open the android PR to integrate this and validate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug Fix
The
ElectrumSyncClientwas incorrectly treating mempool entries (height=0 or -1) fromblockchain.scripthash.get_historyas confirmed transactions. This causedget_merkleto fail since it cannot prove block inclusion for unconfirmed transactions, breaking sync for 0-conf channel funding transactions.Changes
[patch.crates-io]section pointing to ovitrif/[email protected]References
ElectrumSyncClient: Skip unconfirmedget_historyentries lightningdevkit/rust-lightning#4341Test plan
cargo buildsucceedsRelease
🤖 Generated with Claude Code