Skip to content

[NFC] BridgeJS: Avoid emitting empty skeletons #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kateinoigakukun merged 1 commit into from
Feb 4, 2026
Merged

[NFC] BridgeJS: Avoid emitting empty skeletons #574

kateinoigakukun merged 1 commit into from
Feb 4, 2026
+83 −163

Conversation

@kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Feb 4, 2026 •
edited
Loading

Summary

  • omit empty imported file skeletons via ImportedFileSkeleton.isEmpty and filter during collection
  • omit empty exported skeletons so BridgeJS.json only contains meaningful sections
  • add multifile fixture/snapshot test to cover import/export filtering and update snapshots

@kateinoigakukun kateinoigakukun marked this pull request as ready for review February 4, 2026 09:33
@kateinoigakukun kateinoigakukun changed the title BridgeJS: Avoid emitting empty import skeleton BridgeJS: Avoid emitting empty skeletons Feb 4, 2026
fjtrujy
fjtrujy approved these changes Feb 4, 2026
View reviewed changes
Copy link
Contributor

@fjtrujy fjtrujy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kateinoigakukun kateinoigakukun changed the title BridgeJS: Avoid emitting empty skeletons [NFC] BridgeJS: Avoid emitting empty skeletons Feb 4, 2026
@kateinoigakukun kateinoigakukun force-pushed the katei/293e-bridgejs-avoid-e branch from 09bd697 to 3e77198 Compare February 4, 2026 09:45
@kateinoigakukun kateinoigakukun enabled auto-merge (squash) February 4, 2026 09:51
@kateinoigakukun kateinoigakukun merged commit 0bd50f8 into main Feb 4, 2026
11 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/293e-bridgejs-avoid-e branch February 4, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjtrujy fjtrujy fjtrujy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kateinoigakukun @fjtrujy