Skip to content

Fix settings organization flows#1159

Open
ved015 wants to merge 1 commit into
mainfrom
fix/eng_900
Open

Fix settings organization flows#1159
ved015 wants to merge 1 commit into
mainfrom
fix/eng_900

Conversation

@ved015

@ved015 ved015 commented Jun 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Fix delete-organization dialog focus when switching orgs inside Settings.
  • Restyle delete-organization modal to match the app modal theme and remove extra organization icons.
  • Make the organization switcher list scrollable when many orgs exist.
  • Send Create organization directly to onboarding instead of opening the create-org modal.
  • Stop onboarding from completing when org creation fails, show an error toast, and return existing users to the dashboard.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 50f1398 Jun 24 2026, 02:21 PM

@graphite-app graphite-app Bot requested a review from Dhravya June 24, 2026 14:22
@claude

claude Bot commented Jun 24, 2026

Copy link
Copy Markdown

Claude finished @ved015's task in 1m 29s —— View job


Code Review Complete

  • Fetching PR diff
  • Analyzing changes for bugs and security issues
  • Checking surrounding context
  • Submitting review

Result: No issues found — this looks good to ship. ✓

The PR properly fixes dialog focus/state issues when switching orgs, simplifies org creation flow, and makes the org switcher scrollable. All timer cleanups, portal container usage, and error handling are correctly implemented.

Score: 10/10

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 50f1398 Commit Preview URL

Branch Preview URL
Jun 24 2026, 02:23 PM

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Fixes dialog focus/state issues when switching orgs in Settings, simplifies org creation by redirecting to onboarding, and makes the org switcher list scrollable.

Issues found: None — this looks good to ship.

The changes are well-structured:

  • The key={activeOrgId} on the Dialog properly resets state when switching orgs
  • Timer cleanup is handled correctly via refs and cleanup effects
  • The portalContainer prop correctly solves nested dialog focus issues by portaling the delete dialog inside the settings modal
  • The document.body.style.pointerEvents = "" workaround for Radix's stuck pointer-events is appropriately placed
  • Scroll containment with stopPropagation on wheel/touch events is the correct pattern for scrollable areas inside popovers
  • Error handling in onboarding properly shows toast and redirects existing users to dashboard on failure

Score: 10/10

const MODAL_SURFACE_SHADOW =
"0 2.842px 14.211px 0 rgba(0,0,0,0.25), 0.711px 0.711px 0.711px 0 rgba(255,255,255,0.10) inset"

const INSET_SHADOW = "inset 1.313px 1.313px 3.938px rgba(0,0,0,0.7)"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why having these variables of css here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants