Repository navigation
Do not size the caveat slice from the wire length - #52
Merged
Merged
Conversation
CaveatSet.DecodeMsgpack reserved capacity for the number of caveats the array header claimed before reading any of them, so a few bytes could reserve gigabytes. Let append grow the slice as caveats actually decode. Reported in HS 201317.
timflyio
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CaveatSet.DecodeMsgpack reserved capacity for the number of caveats the array header claimed before reading any of them, so a few bytes could reserve gigabytes. Let append grow the slice as caveats actually decode.