Repository navigation
Trim whitespace around tokens when parsing an Authorization header - #50
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
The token list is comma separated, and HTTP allows optional whitespace around the commas. Proxies that fold repeated headers join values with ", ", which made Parse fail with an invalid token prefix error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trim whitespace around each token in
Parseso token lists separated by,are accepted.Problem
Parsesplits an Authorization header on,and reads the prefix of each element up to_. HTTP allows optional whitespace around the commas in a list, and proxies that fold repeated header lines join them with,. A header such asFlyV1 fm2_AAAA, fm2_BBBBfails withinvalid token prefix ' fm2'. The same happens with a space before the comma, which is decoded as invalid base64.Fix
Trim whitespace from each element before splitting off the prefix. Headers without extra whitespace parse exactly as before.
Testing
comma space,space around comma,comma tab) and passes after.go test ./...andgo vet .pass.Fixes #49