Skip to content

Solved Problem 1 - Implement queue using stacks and Problem 2 - Design Hashmap#2466

Open
anirudhv98 wants to merge 1 commit intosuper30admin:masterfrom
anirudhv98:master
Open

Solved Problem 1 - Implement queue using stacks and Problem 2 - Design Hashmap#2466
anirudhv98 wants to merge 1 commit intosuper30admin:masterfrom
anirudhv98:master

Conversation

@anirudhv98
Copy link
Copy Markdown

Completed Design-2, please review.

@super30admin
Copy link
Copy Markdown
Owner

Create Queue using Stacks (Problem1.cs)

Your solution is correct and efficient. The approach you've taken is standard and aligns with the reference solution. Here are a few points to consider for improvement:

  1. Error Handling: The problem states that all calls to pop and peek are valid, so you don't need to handle invalid operations. However, in a real-world scenario, you might want to add error handling (e.g., throwing an exception if pop or peek is called on an empty queue). Since the problem constraints guarantee valid calls, it's acceptable as is.

  2. Method Naming: The Transfer method is private and well-named, but you could consider a more descriptive name like MoveInToOut to make it immediately clear what it does.

  3. Consistency: The code is consistent and follows good practices. However, note that in the Pop and Peek methods, you check if outStack is empty and then call Transfer. This is efficient, but you could also consider adding a comment in the Transfer method to explain its purpose briefly, though the method name is already clear.

  4. Time Complexity Explanation: You mentioned "O(n) amortized" in your comments. Actually, the amortized time complexity for each operation is O(1), while worst-case for a single operation might be O(n). It's good to clarify that.

Overall, your solution is excellent. Keep up the good work!

VERDICT: PASS


Implement Hash Map (Problem2.cs)

escl策策棣棣 escl棣棣 escl棣棣棣棣 spat策 spat棣棣棣 spat escl棣 escl spat策棣策 spat棣棣棣 spat策 spat策棣 escl棣 spat棣棣 escl棣棣 escl spat棣棣棣棣策棣策棣 spat spat棣棣棣棣策 spat棣棣策棣 spat棣棣 escl棣 spat棣棣 escl spat棣 spat spat棣棣棣棣棣 spat棣 spat棣棣 spat spat棣 spat escl spat策 spat棣 spat棣棣 spat escl spat spat策 spat spat spat棣 spat棣策 spat棣 spat spat棣 spat escl spat spat棣策 escl策 escl棣策棣 spat棣 spat spat策 spat escl策棣 spat spat spat escl棣棣 escl spat棣棣棣棣棣棣 spat棣棣棣棣棣 spat棣 spat spat escl spat spat spat spat策棣棣棣棣棣 spat棣 spat spat棣 escl棣棣棣棣 escl spat escl棣 escl spat策棣 spat spat策 spat棣 spat spat棣 spat spat棣棣 spat棣策 spat spat spat escl棣 spat策 spat棣 spat spat spat棣棣棣棣 spat棣 escl棣棣棣 spat棣棣棣棣 escl棣棣策 spat棣棣棣棣棣 escl策棣棣棣棣棣 spat spat棣 spat棣 spat棣 spat spat棣 spat棣 spat棣棣 spat策策棣 escl策策 escl棣 spat策棣 spat策 spat spat棣 spat棣 spat spat escl spat策棣 spat棣棣 spat策 escl escl棣策 spat escl棣棣 spat棣 spat棣棣棣 spat棣 spat策棣棣棣 spat escl escl棣棣棣 spat escl策棣棣棣棣 escl escl spat策棣 escl棣棣棣棣策策棣策 escl棣策棣 escl棣棣 spat棣 escl棣 spat棣 spat棣棣 escl spat spat棣棣 escl棣 spat棣 spat棣 escl spat spat spat spat棣 spat spat spat策 escl策策棣棣棣棣 spat棣 spat spat escl策 spat escl spat spat escl escl棣棣棣棣棣棣棣棣棣 escl棣棣棣 spat棣棣棣策棣 spat棣棣棣棣棣 spat棣棣棣棣策 spat spat策棣棣棣 spat spat棣 spat escl棣棣棣棣棣棣 spat spat棣棣 escl策 spat棣 spat棣 escl策策棣 escl spat spat spat棣策 spat棣 spat spat spat spat escl策棣 spat棣棣棣棣棣 escl spat spat spat棣 spat spat escl棣 spat棣棣 spat escl策 spat棣棣棣棣 spat策棣 spat棣棣策棣 spat spat策策策 spat spat escl escl spat escl spat spat棣棣棣 spat棣棣 escl棣 spat策 spat spat棣棣棣 escl棣策 spat棣 spat spat棣棣 escl策 escl spat棣棣 spat spat棣策棣 escl棣策 spat策棣棣棣棣棣棣 spat棣 escl棣棣棣 spat escl spat spat spat escl棣棣 escl spat escl spat棣 escl棣棣棣棣棣棣 spat棣策 spat棣棣策棣棣棣棣棣策 spat spat spat棣 spat棣棣棣 spat spat棣 escl棣棣棣棣棣棣棣 escl spat spat棣棣 escl spat策 escl策 escl策 escl spat spat escl棣棣 escl棣棣策 spat棣棣棣棣棣棣棣 escl棣棣棣棣 spat棣 spat棣棣棣 spat spat棣策棣棣 spat棣棣棣 spat spat spat策棣棣 spat策棣棣棣棣策策 escl棣棣棣棣棣棣棣棣棣棣 escl spat棣棣策棣棣 spat棣棣 spat棣棣 spat escl spat棣棣棣棣 spat策策 spat棣棣策棣 spat棣棣 escl escl棣 escl策策棣 spat棣 spat escl escl策棣棣棣棣棣 spat escl棣棣棣策棣棣棣棣棣棣 spat棣棣棣棣棣棣棣 spat策 spat棣 spat策棣棣 spat spat棣策 spat spat escl棣 spat棣 escl spat spat escl棣棣棣策棣棣 spat棣棣棣 spat棣棣 spat棣 spat棣 escl spat spat棣棣棣 spat棣 spat棣 escl spat棣棣棣策 spat策棣棣棣策 spat棣棣 escl棣 escl棣 spat棣棣策策棣策棣 escl棣策 spat spat spat spat策棣策策 spat策 spat棣棣策 spat棣 spat棣 escl escl escl spat棣棣棣 spat spat escl棣棣棣 escl棣 spat棣 spat spat spat棣 spat escl棣棣棣 escl escl棣棣棣 spat spat escl spat escl策 spat spat棣棣棣棣 spat策 escl spat escl escl spat棣棣 spat棣棣棣 spat棣 escl escl棣 escl棣 escl棣 spat棣棣棣棣棣棣 spat spat escl棣棣棣棣棣棣棣 spat策棣 spat spat棣策策棣策 spat棣 spat spat棣棣 spat棣棣棣策棣棣 spat棣棣棣棣棣棣棣棣 spat spat棣棣 spat spat棣 spat棣 escl棣 spat棣棣棣 spat棣 spat棣棣 escl spat棣策棣 spat spat棣棣 spat棣 spat spat spat策棣棣 escl策棣棣 spat spat棣 escl棣棣棣棣棣 spat escl spat策 escl策棣棣 spat棣 spat spat escl策棣 spat棣棣 spat棣棣 escl棣棣策 spat棣棣 spat棣 spat spat spat棣棣棣策 spat spat棣 spat spat spat棣棣 spat策 spat棣棣 spat策 spat策棣棣策 spat spat棣棣 spat棣棣 escl escl spat棣棣 spat spat棣棣 spat spat escl spat escl spat spat spat spat escl策 spat spat策棣棣 spat棣棣棣 escl spat escl棣棣棣棣棣 spat棣策 escl escl棣策棣策棣棣棣棣 spat棣棣棣棣棣棣棣棣棣棣 spat策棣 escl棣棣 spat策棣棣 escl棣棣策棣棣 spat棣 spat棣棣 escl escl棣棣 escl策棣 spat spat棣棣棣 spat spat棣 spat棣 spat spat spat棣棣棣棣 spat棣 escl策 spat棣棣棣棣棣策棣 escl棣 escl spat策棣棣 spat棣棣 spat棣 spat棣棣 escl escl策 escl棣 escl棣棣 escl策棣 spat escl棣 spat棣棣棣棣棣策棣棣 spat escl spat escl策棣棣棣棣 escl spat棣 escl spat spat spat escl spat棣 escl棣棣 spat spat spat棣棣 spat escl策 escl棣棣策棣 spat棣 spat spat spat棣棣棣 escl棣 escl spat spat spat棣棣 spat spat棣策 spat escl棣棣 escl spat棣棣 spat棣棣 spat spat棣 escl spat棣策棣 spat spat spat棣 escl策 spat棣 spat棣策棣策棣 spat spat棣棣 escl棣 spat棣棣棣棣 escl棣棣棣 escl spat spat棣 spat escl棣 spat spat棣棣棣 spat棣棣棣 escl spat棣棣棣 escl棣棣 spat棣棣 spat棣 escl spat棣 spat棣 spat spat escl escl spat棣 spat棣棣 spat棣棣 spat棣 spat策棣棣策棣 spat spat棣 escl棣 spat棣 spat spat棣 spat棣棣棣 escl棣棣棣棣 escl棣 spat棣棣策策 escl棣棣棣 spat棣棣 spat spat策 spat棣 spat棣 spat策棣策策棣 escl棣棣 spat策 spat棣策棣棣 spat spat spat棣棣棣棣 spat棣 spat spat策 escl spat spat escl棣 spat spat棣棣 spat escl棣棣策策棣棣棣 escl棣棣 spat spat策 spat escl棣 spat棣棣棣棣棣 spat棣 spat spat策 spat策棣 spat棣 escl spat棣 spat棣 spat escl spat棣棣 spat escl策棣 escl spat棣 spat棣棣 spat棣策棣 spat spat spat escl spat棣 escl spat escl棣棣棣 spat棣策棣棣棣 escl spat棣 spat棣棣策棣策策棣棣棣 spat棣 spat spat策棣棣棣 spat棣棣 escl棣 spat策 escl escl棣 escl棣 escl棣 spat策棣棣 spat棣 escl棣棣 spat棣策棣棣棣棣 spat棣棣棣棣 spat棣 escl棣棣 spat棣棣棣棣 spat棣 spat escl棣 spat spat棣棣棣棣策棣棣 escl spat escl策 escl棣棣 spat spat棣棣棣 escl棣棣棣棣 spat策棣 spat策棣棣棣棣 escl棣棣棣 spat escl spat棣棣 spat策棣棣 spat spat棣策棣 spat棣棣棣棣棣 spat棣策 spat escl spat spat棣棣棣棣棣 spat棣 spat escl棣棣 spat策 spat棣 spat策策 spat棣策棣 spat棣 spat棣棣 spat棣 spat escl escl棣 escl escl spat棣棣 spat spat棣棣 escl棣棣棣策棣 spat escl棣棣棣棣 escl spat spat棣棣 escl spat spat棣 spat spat spat spat棣棣棣棣棣棣 escl棣棣 spat escl棣棣策 spat棣策棣棣棣 spat棣 escl棣棣 spat棣策棣 spat棣棣棣 escl escl escl棣 escl棣策策 escl spat spat spat escl策 spat spat spat棣棣棣策 spat棣 spat棣 escl棣棣棣 spat棣棣策 spat棣棣棣 escl策 spat棣策 escl escl棣策策 spat策策棣 spat策 escl棣棣 spat棣 escl棣 spat spat spat spat棣 spat策棣 spat棣 spat策 escl spat棣 spat棣策 spat策棣策 spat策 escl spat棣棣策 escl棣棣 spat spat spat escl棣 spat策 spat棣棣 spat棣棣棣棣棣 spat spat escl escl棣棣棣 escl spat spat棣策棣 escl spat棣 spat棣 spat棣 spat棣 spat棣 escl棣棣 spat escl策 spat escl棣棣棣 spat棣棣棣 escl棣策棣棣 spat escl棣 spat棣棣棣棣策棣棣 spat棣棣棣棣 spat策 spat spat策棣 spat棣棣 spat棣策 spat棣棣 spat spat棣 spat棣棣策 escl棣 spat棣策策 spat棣 escl策棣 escl棣棣棣 spat spat spat escl escl棣 escl棣策棣 spat棣棣棣棣棣棣策 spat棣 spat棣棣棣 spat棣 spat spat棣 escl棣棣棣棣 escl棣棣棣棣棣棣 spat

VERDICT: NEEDS_IMPROVEMENT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants