feat(db): support edge function names in webhook triggers#4629
Open
JEETDESAI25 wants to merge 1 commit intosupabase:developfrom
Open
feat(db): support edge function names in webhook triggers#4629JEETDESAI25 wants to merge 1 commit intosupabase:developfrom
JEETDESAI25 wants to merge 1 commit intosupabase:developfrom
Conversation
Contributor
|
I think this is a good idea. But we also need to be consistent with the webhooks definition on platform side. Let me check with our team and get back on whether something similar can be rolled out on all hosted projects. |
Author
|
Thanks for the review! Let me know what changes are needed to better align with platform side definition. |
Comment on lines
+47
to
+48
| base_url text; | ||
| service_key text; |
Contributor
There was a problem hiding this comment.
possibly alternative https://gist.github.com/TheOtherBrian1/d176d1d2656b23c6b537afca3dbfb901
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Refs: #1705, supabase/supabase#34139
Webhooks require full URLs, breaking when migrating between environments.
What is the new behavior?
supabase_functions.http_request()auto-detects slugs vs URLs, reads secrets from vault, injects Authorization headerstart,db push,db reset,migration up/down