init commit, tldr the cache_dir or files should probably indicate tab…#835
Draft
init commit, tldr the cache_dir or files should probably indicate tab…#835
Conversation
Collaborator
Author
|
Don't know how to change this to a draft. But, will keep iterating on this as I move along. |
jhnwu3
requested review from
EricSchrock and
Logiquo
and removed request for
Logiquo
Logiquo
reviewed
Feb 12, 2026
pyhealth/datasets/base_dataset.py
Outdated
Comment on lines
376
to
381
| if self._cache_dir is None: | ||
| # No cache_dir provided: use default pyhealth cache directory | ||
| cache_dir = Path(platformdirs.user_cache_dir(appname="pyhealth")) / "datasets" | ||
| cache_dir.mkdir(parents=True, exist_ok=True) | ||
| logger.info(f"No cache_dir provided. Using default cache dir: {cache_dir}") | ||
| self._cache_dir = cache_dir |
Collaborator
There was a problem hiding this comment.
Because all task files are still in the same .../tasks/{task.task_name}_{uuid.uuid5(uuid.NAMESPACE_DNS, task_params)}/...
For the same task with same schema, same processor, but different dataset, it will still collide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem here is it can be quite confusing for the user to know exactly what tables are cached inside each cache file when they want to specify a new location.