Skip to content

Build on Linux cleaned up + Improved error handling on GoogleAuthManager for Android, iOS, and JVM.#14

Merged
sunildhiman90 merged 1 commit into
sunildhiman90:mainfrom
rylexr:feat/improve-error-handling
May 12, 2026
Merged

Build on Linux cleaned up + Improved error handling on GoogleAuthManager for Android, iOS, and JVM.#14
sunildhiman90 merged 1 commit into
sunildhiman90:mainfrom
rylexr:feat/improve-error-handling

Conversation

@rylexr

@rylexr rylexr commented May 10, 2026

Copy link
Copy Markdown
Contributor
  • Removed non-required call to binaries.executable() from all Gradle Build files - This call is not required for libraries, and it also breaks building the library on Linux.
  • Changed code on GoogleAuthManager (Android, iOS, and JVM) from continuation.resume(Result.failure(Exception("Error in google Sign In: $error"))) to continuation.resume(Result.failure(error)) to avoid swallowing the original exception. This is useful when you want to display the original exception message on the UI client.

…e Build files - Call is not required for libraries, and it also breaks building the library on Linux

+ Changed code on `GoogleAuthManager` (Android, iOS, and JVM): `continuation.resume(Result.failure(Exception("Error in google Sign In: $error")))` to `continuation.resume(Result.failure(error))` to avoid swallowing the original exception. This is useful when you want to display the original exception message on the UI client.
@sunildhiman90 sunildhiman90 merged commit aa8c20b into sunildhiman90:main May 12, 2026
1 check passed
@rylexr rylexr deleted the feat/improve-error-handling branch May 12, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants