🌐(i18n) rename cn_CN to zh_CN, add eo_PL and zh_TW locales#2486
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
WalkthroughThis pull request adds Esperanto and Traditional Chinese Django gettext catalogs, updates Simplified Chinese translations, removes the previous Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/backend/locale/eo_PL/LC_MESSAGES/django.po`:
- Around line 44-46: The translation for the “Tree structure” msgid in the eo_PL
django.po catalog uses a misleading forest-related phrase. Update the msgstr for
that entry to a tree-specific Esperanto term such as Arbostrukturo or arba
strukturo, keeping the existing msgid unchanged and making sure the locale entry
in the gettext catalog matches the UI label used by core/admin.py.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: e26af987-ce0a-450b-8310-9f00b06d713a
📒 Files selected for processing (4)
src/backend/locale/cn_CN/LC_MESSAGES/django.posrc/backend/locale/eo_PL/LC_MESSAGES/django.posrc/backend/locale/zh_CN/LC_MESSAGES/django.posrc/backend/locale/zh_TW/LC_MESSAGES/django.po
💤 Files with no reviewable changes (1)
- src/backend/locale/cn_CN/LC_MESSAGES/django.po
AntoLC
left a comment
AntoLC
left a comment
There was a problem hiding this comment.
Thank you for your contribution 🎉
AntoLC
changed the title
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@documentation/languages-configuration.md`:
- Line 123: Update the eo_PL entry in the language configuration documentation
to state that eo-pl is an administrative project locale identifier using
Poland’s code because Esperanto has no associated country code, not a
Poland-specific linguistic variant.
In `@src/backend/locale/zh_CN/LC_MESSAGES/django.po`:
- Around line 240-245: Update the Chinese translations for “first connection
status” and “Whether the user has completed the first connection process.” in
the locale catalog to preserve the source meaning of first connection, using
“首次连接” wording rather than “首次登录,” unless the product explicitly defines the
field as login-specific.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8e4fa6fa-20d6-4314-aaa9-8f28059ed3b5
📒 Files selected for processing (5)
documentation/languages-configuration.mdsrc/backend/locale/cn_CN/LC_MESSAGES/django.posrc/backend/locale/eo_PL/LC_MESSAGES/django.posrc/backend/locale/zh_CN/LC_MESSAGES/django.posrc/backend/locale/zh_TW/LC_MESSAGES/django.po
💤 Files with no reviewable changes (1)
- src/backend/locale/cn_CN/LC_MESSAGES/django.po
| - `cn_CN` - Chinese (China) - *Note: Use `zh-cn` in DJANGO_LANGUAGES* | ||
| - `de_DE` - German (Germany) - Use `de-de` | ||
| - `en_US` - English (United States) - Use `en-us` | ||
| - `eo_PL` - Esperanto - Use `eo-pl` |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Document that eo-pl is an administrative placeholder.
Because Esperanto has no associated country code, clarify here that eo-pl is a project locale identifier using Poland administratively—not a Poland-specific linguistic variant.
Suggested clarification
- `eo_PL` - Esperanto - Use `eo-pl`
+ (`eo-pl` uses `PL` as an administrative placeholder; it is not a regional Esperanto variant.)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@documentation/languages-configuration.md` at line 123, Update the eo_PL entry
in the language configuration documentation to state that eo-pl is an
administrative project locale identifier using Poland’s code because Esperanto
has no associated country code, not a Poland-specific linguistic variant.
| msgid "first connection status" | ||
| msgstr "" | ||
| msgstr "首次登录状态" | ||
|
|
||
| #: core/models.py:201 | ||
| msgid "Whether the user has completed the first connection process." | ||
| msgstr "" | ||
| msgstr "标识用户是否已完成首次登录引导流程。" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Preserve the “first connection” meaning.
The source says “first connection process,” but this translation changes it to “首次登录” (“first login”). Use wording such as “首次连接状态” and “首次连接引导流程” unless the product intentionally defines this field as login-specific.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/backend/locale/zh_CN/LC_MESSAGES/django.po` around lines 240 - 245,
Update the Chinese translations for “first connection status” and “Whether the
user has completed the first connection process.” in the locale catalog to
preserve the source meaning of first connection, using “首次连接” wording rather
than “首次登录,” unless the product explicitly defines the field as login-specific.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@documentation/languages-configuration.md`:
- Line 135: Update the zh_TW language entry to explicitly identify it as
Traditional Chinese, using wording such as “Traditional Chinese (Taiwan)” or
“Chinese (Traditional, Taiwan)”, while preserving the existing zh-tw code.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 5dfff96f-8021-40bf-abb3-8f4ea6d6704a
📒 Files selected for processing (6)
CHANGELOG.mddocumentation/languages-configuration.mdsrc/backend/locale/cn_CN/LC_MESSAGES/django.posrc/backend/locale/eo_PL/LC_MESSAGES/django.posrc/backend/locale/zh_CN/LC_MESSAGES/django.posrc/backend/locale/zh_TW/LC_MESSAGES/django.po
💤 Files with no reviewable changes (1)
- src/backend/locale/cn_CN/LC_MESSAGES/django.po
We have renamed the Chinese locale from `cn_CN` to `zh_CN` to align with standard locale naming conventions. Additionally, we have added support for two new locales: Esperanto (`eo_PL`) and Traditional Chinese (`zh_TW`).
2 participants
i18n: fix zh locale codes and add Esperanto
cn-CN→zh-CN(correct BCP 47 language code)zh-TWfor Traditional Chinese (Taiwan conventions)eo)eo-PLas a placeholderla-ITfor Latin