Skip to content

💄(frontend) Restyle the editor divider block#2483

Merged
PanchoutNathan merged 1 commit into
mainfrom
feature/present-mode-divider-style
Jul 21, 2026
Merged

💄(frontend) Restyle the editor divider block#2483
PanchoutNathan merged 1 commit into
mainfrom
feature/present-mode-divider-style

Conversation

@PanchoutNathan

Copy link
Copy Markdown
Contributor

Summary

  • Slim the editor divider to match the approved mockups.
  • Add the selected divider state with the brand color.

Issues

Refs #2466
Closes #2474

@PanchoutNathan PanchoutNathan self-assigned this Jul 1, 2026
@PanchoutNathan
PanchoutNathan marked this pull request as draft July 1, 2026 11:58
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 4.37 MB

📦 View Changed
Filename Size Change
apps/impress/out/_next/static/d6eb12d5/_buildManifest.js 696 B +696 B (new file) 🆕
apps/impress/out/_next/static/f3d3b484/_buildManifest.js 0 B -696 B (removed) 🏆

compressed-size-action

Slim the divider to a 1px rule with a brand-colored selected state,
matching the mockups.

Closes #2474
@PanchoutNathan
PanchoutNathan force-pushed the feature/present-mode-divider-style branch from d3eee2b to 5a8f696 Compare July 20, 2026 08:54
@PanchoutNathan
PanchoutNathan requested review from AntoLC and Ovgodd July 20, 2026 09:09
@PanchoutNathan
PanchoutNathan marked this pull request as ready for review July 21, 2026 08:13
@PanchoutNathan
PanchoutNathan merged commit 5a8f696 into main Jul 21, 2026
49 of 52 checks passed
@PanchoutNathan
PanchoutNathan deleted the feature/present-mode-divider-style branch July 21, 2026 08:13
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f8701324-cdff-4a05-a5a0-f20a67d85628

📥 Commits

Reviewing files that changed from the base of the PR and between 708fa83 and 5a8f696.

📒 Files selected for processing (1)
  • src/frontend/apps/impress/src/features/docs/doc-editor/styles.tsx

Walkthrough

Updated divider styles to use a 28px centered block layout, contextual theme variables, and revised selected-state border, outline, and background behavior. The side-menu divider height was also reduced from 38px to 28px.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: ovgodd

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/present-mode-divider-style

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update divider style

2 participants