⬆️(deps) align react-aria and drop the @adobe/react-spectrum chain#400
Open
sylvinus wants to merge 1 commit into
Open
⬆️(deps) align react-aria and drop the @adobe/react-spectrum chain#400sylvinus wants to merge 1 commit into
sylvinus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
packages/reactexact-pins the react-aria ecosystem at stale versions.Two consequences in consuming apps:
react-stately@3.45.0,ui-kit pins
3.37.0, apps pull others; npm/yarn can't hoist one copyand nest dozens (the
@react-aria/*tree alone duplicated to ~1.9 GB).@react-aria/calendar@3.9.5/
@react-aria/datepicker@3.16.1(and their@react-stately/*siblings)still depend on the mispackaged
@react-types/button@3.16.0, whichdepends on
@react-spectrum/button→@adobe/react-spectrum(the fullcomponent suite). Nothing uses Spectrum; it's pure transitive bloat.
Measured in a consuming app:
node_modules3.2 GB → 0.65 GB, with@adobe/react-spectrum,@react-spectrum/*,@spectrum-icons/*fullyremoved.
Change
Align every react-aria package to a single consistent release. The key
constraint: react-aria's meta packages exact-pin
react-statelyinternally, and
react-aria@3.50.0+react-aria-components@1.19.0arethe latest pair that agree on
react-stately@3.48.0.The calendar/datepicker bumps are what sever the
@react-types/*→@adobeedge. No source or API changes.
Lockfile
yarn.lockregenerated:@adobe/react-spectrum,@react-spectrum/*,@spectrum-icons/*are gone; singlereact-stately@3.48.0.yarn build+yarn testgreen.