PDF: add pan across x axis by pressing space and moving the mouse

[kenekoba]

Hi,

almost all PDF viewer softwares allow the user to scroll x axis by pressing space and moving (dragging) the mouse

this feature is not needed in laptops because of touchpad but in desktop that only has mouse & keyboard it's needed

[taylorhadden]

My primary thought here is: should we instead be panning with a Right click & drag or with a Space + LMB & Drag?

[kenekoba]

My primary thought here is: should we instead be panning with a Right click & drag or with a Space + LMB & Drag?

we may need to reserve right click operations for future features (e.g. highlight, other operations, etc)

[taylorhadden]

Thanks for making these changes! Just a small note about the css.

I'll see how Space + Drag feels. I anticipate that I will change it to be a Space + LMB + Drag gesture, but we'll see.

[taylorhadden]

You need to use &.panning here to have it affect the container as well. This selector compiles to article .container .panning and using & gives you article .container.panning.

[kenekoba]

the panning class is applied to the viewerElement not the container itself:

		<div class="container pdfViewer" bind:this={container}>
			<!-- svelte-ignore a11y-click-events-have-key-events -->
			<!-- svelte-ignore a11y-no-static-element-interactions -->
			<div bind:this={viewerElement} class={{ 'panning': isPanning }} on:mousemove={onMouseMove} on:click={onClick}></div>
		</div>

[taylorhadden]

Not sure why this is showing up as changed. Ideally it's not in the PR.

[taylorhadden]

Oh, I see your other comment now. That's annoying! Windows' terrible file management issues rise again. I should shorten that filename…

[kenekoba]

the stupid part is that I've managed to restore the file by Github web editor, but it's still listed as changed files, despite that I've copied the file content exactly as it was

[kenekoba]

I'll see how Space + Drag feels. I anticipate that I will change it to be a Space + LMB + Drag gesture, but we'll see.

OK, I think I'm done here.
choose what feels more natural

as a reminder, I've added another feature where pressing shift while scrolling changes the scroll direction. (web browsers implement this feature)