Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,93 @@ describe('spend-request', () => {
});
});

describe('activity_url', () => {
it('RetrieveSpendRequest shows activity_url in finalized phase', async () => {
const request = makeSpendRequest({
status: 'succeeded',
activity_url: 'https://activity.link.com/tx_123',
});
const repo = makeMockRepo(request);

const { lastFrame } = render(
<RetrieveSpendRequest
repository={repo}
id="sr_test"
onComplete={() => {}}
/>,
);

await vi.waitFor(() => {
const frame = lastFrame();
expect(frame).toContain('Activity URL');
expect(frame).toContain('https://activity.link.com/tx_123');
});
});

it('RetrieveSpendRequest shows link_transaction_id in finalized phase', async () => {
const request = makeSpendRequest({
status: 'succeeded',
link_transaction_id: 'ltxn_abc123',
});
const repo = makeMockRepo(request);

const { lastFrame } = render(
<RetrieveSpendRequest
repository={repo}
id="sr_test"
onComplete={() => {}}
/>,
);

await vi.waitFor(() => {
const frame = lastFrame();
expect(frame).toContain('Transaction ID');
expect(frame).toContain('ltxn_abc123');
});
});

it('RetrieveSpendRequest omits activity_url on failed status even when present', async () => {
const request = makeSpendRequest({
status: 'failed',
activity_url: 'https://activity.link.com/tx_123',
});
const repo = makeMockRepo(request);

const { lastFrame } = render(
<RetrieveSpendRequest
repository={repo}
id="sr_test"
onComplete={() => {}}
/>,
);

await vi.waitFor(() => {
const frame = lastFrame();
expect(frame).toContain('terminal status');
expect(frame).not.toContain('Activity URL');
});
});

it('RetrieveSpendRequest omits activity_url when absent in finalized phase', async () => {
const request = makeSpendRequest({ status: 'succeeded' });
const repo = makeMockRepo(request);

const { lastFrame } = render(
<RetrieveSpendRequest
repository={repo}
id="sr_test"
onComplete={() => {}}
/>,
);

await vi.waitFor(() => {
const frame = lastFrame();
expect(frame).toContain('terminal status');
expect(frame).not.toContain('Activity URL');
});
});
});

describe('sanitization', () => {
it('CreateSpendRequest sanitizes merchant_name and line_items', async () => {
const request = makeSpendRequest();
Expand Down
17 changes: 17 additions & 0 deletions packages/cli/src/commands/spend-request/retrieve.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,23 @@ export const RetrieveSpendRequest: React.FC<RetrieveSpendRequestProps> = ({
)}
</Box>
)}
{request?.link_transaction_id && (
<Box marginTop={1}>
<Text>
Transaction ID: <Text bold>{request.link_transaction_id}</Text>
</Text>
</Box>
)}
{request?.status === 'succeeded' && request?.activity_url && (
<Box marginTop={1}>
<Text>
Activity URL:{' '}
<Text bold color="cyan">
{request.activity_url}
</Text>
</Text>
</Box>
)}
</Box>
</Box>
);
Expand Down
2 changes: 2 additions & 0 deletions packages/sdk/src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@ export interface SpendRequest {
shared_payment_token?: SharedPaymentToken;
link_pay_token?: string;
payment_status_details?: PaymentStatusDetails | null;
link_transaction_id?: string;
activity_url?: string;
created_at: string;
updated_at: string;
}
Expand Down
Loading