fix(telemetry): added latest semantic conventions as span attributes for langfuse#1768
Merged
poshinchen merged 1 commit intostrands-agents:mainfrom Feb 27, 2026
Conversation
8cc9772 to
fee77b9
Compare
|
Assessment: Request Changes Good approach to handling Langfuse's span attribute requirements. The implementation correctly adds event attributes to span attributes when using Langfuse as the OTLP endpoint. Review Summary
Once the duplicated check is replaced with |
fee77b9 to
d6086d3
Compare
afarntrog
requested changes
Feb 26, 2026
d6086d3 to
1cc145d
Compare
afarntrog
previously approved these changes
Feb 26, 2026
JackYPCOnline
previously approved these changes
Feb 27, 2026
1cc145d to
a28e96d
Compare
7 tasks
545b630
a28e96d to
545b630
Compare
|
Assessment: Approve The previous feedback has been addressed. The implementation now correctly uses Review Summary
Nice work on this fix! 🎉 |
afarntrog
approved these changes
Feb 27, 2026
JackYPCOnline
approved these changes
Feb 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently Langfuse do not read some of the latest semantic conventions via event attributes, instead they read from the span attributes. Therefore we have to add those event attributes into span attributes when users are using langfuse.
Related Issues
N/A
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.