fix: prevent assistant-first tool-use history after context reduction#1750
Open
KKamJi98 wants to merge 1 commit intostrands-agents:mainfrom
Open
fix: prevent assistant-first tool-use history after context reduction#1750KKamJi98 wants to merge 1 commit intostrands-agents:mainfrom
KKamJi98 wants to merge 1 commit intostrands-agents:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
SlidingWindowConversationManager.reduce_context()can produce invalid history for Gemini in long tool-heavy chats:_truncate_tool_results()aborts early when latesttoolResultis already truncated.toolUseas the first message.Gemini rejects this with
400 INVALID_ARGUMENT(function call turn ...). This change keeps context reduction stable while preserving existing behavior for assistant text-only starts.Resolves #1749
Public API Changes
No public API changes.
What changed
toolResultentries when the latest candidate cannot be truncated.toolResultentries instead of returning early from_truncate_tool_results().toolUse(function-call start), preventing invalid Gemini turn order.Related Issues
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.