Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/strands/models/mistral.py
Original file line number Diff line number Diff line change
Expand Up @@ -496,8 +496,8 @@ async def stream(

yield self.format_chunk({"chunk_type": "message_stop", "data": choice.finish_reason})

if hasattr(chunk, "usage"):
yield self.format_chunk({"chunk_type": "metadata", "data": chunk.usage})
if hasattr(chunk, "data") and hasattr(chunk.data, "usage") and chunk.data.usage:
yield self.format_chunk({"chunk_type": "metadata", "data": chunk.data.usage})

except Exception as e:
if "rate" in str(e).lower() or "429" in str(e):
Expand Down
32 changes: 28 additions & 4 deletions tests/strands/models/test_mistral.py
Original file line number Diff line number Diff line change
Expand Up @@ -451,9 +451,9 @@ async def test_stream(mistral_client, model, agenerator, alist, captured_warning
delta=unittest.mock.Mock(content="test stream", tool_calls=None),
finish_reason="end_turn",
)
]
],
usage=mock_usage,
),
usage=mock_usage,
)

mistral_client.chat.stream_async = unittest.mock.AsyncMock(return_value=agenerator([mock_event]))
Expand All @@ -476,6 +476,30 @@ async def test_stream(mistral_client, model, agenerator, alist, captured_warning
assert len(captured_warnings) == 0


@pytest.mark.asyncio
async def test_stream_no_usage(mistral_client, model, agenerator, alist):
mock_event = unittest.mock.Mock(
data=unittest.mock.Mock(
choices=[
unittest.mock.Mock(
delta=unittest.mock.Mock(content="test stream", tool_calls=None),
finish_reason="end_turn",
)
],
usage=None,
),
)

mistral_client.chat.stream_async = unittest.mock.AsyncMock(return_value=agenerator([mock_event]))

messages = [{"role": "user", "content": [{"text": "test"}]}]
response = model.stream(messages, None, None)

# Should complete without error and not yield a metadata chunk
chunks = await alist(response)
assert not any("metadata" in c for c in chunks if isinstance(c, dict))


@pytest.mark.asyncio
async def test_tool_choice_not_supported_warns(mistral_client, model, agenerator, alist, captured_warnings):
tool_choice = {"auto": {}}
Expand All @@ -492,9 +516,9 @@ async def test_tool_choice_not_supported_warns(mistral_client, model, agenerator
delta=unittest.mock.Mock(content="test stream", tool_calls=None),
finish_reason="end_turn",
)
]
],
usage=mock_usage,
),
usage=mock_usage,
)

mistral_client.chat.stream_async = unittest.mock.AsyncMock(return_value=agenerator([mock_event]))
Expand Down
5 changes: 5 additions & 0 deletions tests_integ/models/test_model_mistral.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,11 @@ async def test_agent_stream_async(agent):

assert all(string in text for string in ["12:00", "sunny"])

assert result.metrics.accumulated_usage is not None
assert result.metrics.accumulated_usage["inputTokens"] > 0
assert result.metrics.accumulated_usage["outputTokens"] > 0
assert result.metrics.accumulated_usage["totalTokens"] > 0


def test_agent_structured_output(non_streaming_agent, weather):
tru_weather = non_streaming_agent.structured_output(type(weather), "The time is 12:00 and the weather is sunny")
Expand Down
Loading