Conversation
Add F2008 Format_Item class (R1003) in Fortran2008/format_item_r1003.py that extends the F2003 Format_Item with support for the unlimited format repeat specifier '*' before a parenthesised format-item-list. The F2008 class registers itself in Base.subclasses["Format_Item"] so that it is discovered when F2003 code (e.g. Format_Item_List.match) directly references the F2003 Format_Item class. Tests moved to the Fortran2008 test directory.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 92.19% 92.21% +0.01%
==========================================
Files 86 87 +1
Lines 13807 13832 +25
==========================================
+ Hits 12730 12755 +25
Misses 1077 1077 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Unfortunately, when I run the tests locally (under 3.14) with coverage switched on I get test failures :-( The CPP directive match method gets a FortranStringReader instead of a str. If I put in a debugger breakpoint for this situation and run the tests without |
Member
Author
|
This one is also ready for review now. It takes on the PR of @perazz and just fixes coverage and tidies a bit. |
perazz
approved these changes
Mar 13, 2026
sergisiso
approved these changes
Mar 19, 2026
|
Appreciate it @sergisiso, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes on the PR by @perazz to fix the coverage issues.