Point the smart wallet kits at their canonical repos and drop the legacy label - #110
Merged
Merged
Conversation
…acy label Both kalepail/smart-account-kit and kalepail/passkey-kit are archived and moved. Their descriptions read "[MOVED -> github.com/stellar/...]". Point every link at the stellar org instead. The skills also framed passkey-kit as a legacy SDK superseded by smart-account-kit. Neither canonical README says that. The passkey-kit README describes the two as siblings with different on-chain authorization models that are not drop-in compatible, and asks the reader to pick the model that fits the app. Carry that wording instead, and add a short comparison table to smart-accounts.md so the choice is explicit. The same stale links and the same label were in standards/resources.md and standards/ecosystem.md, so correct them in the same pass.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates smart-wallet documentation to align with canonical Stellar repositories and upstream SDK positioning.
Changes:
- Replaces archived repository links with canonical Stellar links.
- Removes unsupported legacy/recommended labels.
- Documents the kits’ distinct authorization models.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
skills/standards/resources.md |
Updates SDK links and descriptions. |
skills/standards/ecosystem.md |
Clarifies sibling SDK models and use cases. |
skills/dapp/smart-accounts.md |
Adds a kit comparison and canonical resources. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
🤖 Automated message from Kaan's Automated Triage Bot. Picked this up — assessing whether I can ship an airtight fix. |
3 tasks
Contributor
Author
|
🤖 Automated message from Kaan's Automated Triage Bot. Merged as I verified before the merge:
The deployed page on skills.stellar.org matches. Raven has the handoff for sk-017. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated message from Kaan's Automated Triage Bot.
Closes #108
Two problems in
skills/dapp/smart-accounts.md, both confirmed.Stale links.
kalepail/smart-account-kitandkalepail/passkey-kitare both archived. The GitHub API returnsarchived: trueand a description of[MOVED → github.com/stellar/...]for each. The links now point atstellar/smart-account-kitandstellar/passkey-kit, which are live and not archived.Unsupported label. The file called passkey-kit a "Legacy SDK". No canonical README says that. The
stellar/passkey-kitREADME describes the two kits as siblings with different on-chain authorization models that are "not drop-in compatible", and asks the reader to "pick the model that fits your app". A full-text scan forlegacy,precursor,greenfield,new project,deprecat, andsupersedefound no kit-level legacy claim; thelegacyhits are about signer generations, the 1-9 contract error range, and superseded tuple events. Thestellar/smart-account-kitREADME never mentions passkey-kit at all.So this drops the label and adds a short comparison table: context rules plus auth digest for smart-account-kit, a flat multi-signer
Signaturesmap for passkey-kit. That is the boundary the README states.Scope note. The issue names
smart-accounts.md. The same two archived links and the same legacy label were also inskills/standards/resources.mdandskills/standards/ecosystem.md, so I corrected them in the same pass rather than leave known-broken links behind. Happy to split that into its own PR if you prefer.The change is markdown under
skills/only. The site build does not read these files, solint,lint:ts, andbuildare unaffected.