Add --enable-fastdev-unsafe-for-production, subsuming unified buid#5298
Add --enable-fastdev-unsafe-for-production, subsuming unified buid#5298graydon wants to merge 7 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new unsafe fast development Rust build mode intended to reduce local build time and binary size by using a lighter Rust profile and compiling fewer Soroban host versions.
Changes:
- Adds
--enable-fastdev-unsafe-for-productionconfigure/build plumbing. - Introduces a
fastdevCargo profile and feature. - Gates older Soroban protocol modules/caches out of fastdev builds and updates docs.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
configure.ac |
Adds the fastdev configure option and sanitizer messaging updates. |
src/Makefile.am |
Wires fastdev into Rust toolchain/profile/features and Soroban protocol selection. |
Cargo.toml |
Defines the root fastdev Rust profile. |
Cargo.lock |
Updates locked Soroban/XDR git dependencies. |
src/rust/Cargo.toml |
Replaces unified feature docs/dependencies with fastdev feature wiring. |
src/rust/src/soroban_proto_all.rs |
Excludes older hosts in fastdev and adjusts dispatch tests. |
src/rust/src/soroban_module_cache.rs |
Gates older module caches and dispatches cache operations via selected host module. |
src/rust/src/soroban_test_extra_protocol.rs |
Gates p22-only test resource modification out of fastdev. |
CONTRIBUTING.md |
Updates developer documentation from unified Rust builds to fastdev builds. |
3a2411a to
1cc328c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1cc328cf5d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@graydon should we have github ci build and run with fastdev? It should speed up CI compilation time, and Jenkins will still run the full SSC suite without fastdev. We also don't need to make that decision now. |
This is a proposal for how to address #5267 in the short term. Longer term we might need some more involved fixes, but this should make life much nicer day-to-day for stellar-core devs.
It adds a new mode
--enable-fastdev-unsafe-for-productionwhich:Results:
Before:
After: