Remove unused dependencies and dead code - #2760
Open
leighmcculloch wants to merge 3 commits into
Open
leighmcculloch wants to merge 3 commits into
leighmcculloch wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The only remaining feedback is a non-blocking cleanup nit.
Review effort: Lite
Findings: None
What changed in this PR
Removes unused dependencies, stale lint allowances, and no-op build logic across the workspace.
Changes:
- Cleans unused dependencies and updates
Cargo.lock. - Restricts test-only helpers and removes obsolete allowances.
- Removes no-op build-script logic.
| File | Summary |
|---|---|
cmd/soroban-cli/src/utils.rs |
Restricts a helper to tests. |
cmd/soroban-cli/src/print.rs |
Removes stale dead-code allowances. |
cmd/soroban-cli/Cargo.toml |
Removes unused dependencies. |
cmd/soroban-cli/build.rs |
Removes no-op build logic; a matching helper remains elsewhere as a nit. |
cmd/crates/stellar-ledger/src/emulator_test_support/speculos.rs |
Removes stale allowances. |
cmd/crates/stellar-ledger/src/emulator_test_support/http_transport.rs |
Removes stale allowance. |
cmd/crates/stellar-ledger/Cargo.toml |
Removes unused dependencies. |
cmd/crates/soroban-test/Cargo.toml |
Removes unused dependencies. |
cmd/crates/soroban-spec-typescript/Cargo.toml |
Removes unused dependencies. |
cmd/crates/soroban-spec-tools/Cargo.toml |
Removes unused dev-dependencies. |
Cargo.toml |
Removes unused workspace dependencies. |
Cargo.lock |
Updates the resolved dependency graph. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove unused dependencies across soroban-cli, stellar-ledger, soroban-spec-typescript, soroban-spec-tools and soroban-test, along with a no-op build script function and stale
allowattributes.Why
The compiler's
unused_crate_dependencieslint and a code search show nothing uses them, and they add build time and lockfile churn.Known limitations
N/A