fix(cli): sync fish completions and command docs with locale surface

[vincent-peng]

Fish completions had fallen behind the multilingual CLI: locale choices were incomplete, and summarize daemon --locale offered daemon commands as locale values. This restores the shipped locale and existing flag choices across commands and documents interface-language selection.

Validation: the old completion file reproduced the wrong candidates in fish; the updated completion file and alias now pass behavioral regression coverage. pnpm install --frozen-lockfile && pnpm check passed on Linux (3,588 tests; 92.07% statement coverage), and the focused package test passed with fish installed. Independent P0–P2 review completed without actionable findings.

Thanks @vincent-peng for the fix. No stored configuration or runtime contract changes.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs maintainer review before merge. Reviewed September 24, 2026, 6:07 AM ET / 10:07 UTC (Revision 2).

ClawSweeper review

What this changes

The branch updates fish suggestions for existing CLI locales and flags, adds command documentation and a changelog entry, and adds completion regression checks.

Merge readiness

✅ Ready for maintainer review

This remains a focused repair worth reviewing. Current main and v0.23.0 still have stale fish suggestions, while the prior review recorded direct completion output for the repair. No blocking defect was identified in the latest head.

Priority: P3
Reviewed head: 8d2f3ac2371e354c98fcce5734818bb579fca58a

Review scores

Measure	Result	What it means
Overall readiness	🐚 platinum hermit (4/6)	Direct fish behavior evidence and focused registry checks support a solid, bounded repair.
Proof confidence	🐚 platinum hermit (4/6)	Sufficient (terminal): The prior completed review records a contributor terminal transcript exercising the changed fish rules and observing corrected locale and command suggestions. The latest head adds a fish execution test without changing those production rules; no stored-data contract changes.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Verification

Check	Result	Evidence
Real behavior	Verified	Sufficient (terminal): The prior completed review records a contributor terminal transcript exercising the changed fish rules and observing corrected locale and command suggestions. The latest head adds a fish execution test without changing those production rules; no stored-data contract changes.
Evidence reviewed	7 items	Repository policy: The full root policy was read; no nested AGENTS.md or matching maintainer notes were found. Its CLI and core ownership guidance informed the review. Introduced completion behavior: The pinned PR delta adds registered locale candidates across command contexts and prevents daemon child commands from appearing after an option token. Existing CLI contract: The shared catalog registers 14 interface locales; the CLI resolves locale before dispatch and removes locale arguments before subcommand handling.
Findings	None	None.
Security	None	None.

How this fits together

Summarize’s fish completion file turns partially typed CLI commands into suggested flags and values. The CLI locale registry and command handlers define which suggestions are valid.

flowchart LR
  A[Typed fish command] --> B[Completion rules]
  C[Registered locales] --> B
  D[CLI flag contracts] --> B
  B --> E[Suggested flags and values]
  E --> F[CLI command]

Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

Metric	Value	Why it matters
Locale completion coverage	7 command contexts; 14 locales plus auto	The new checks compare each context with the existing locale registry.

Technical review

Best possible solution:

Keep fish suggestions aligned with the registered locales and existing CLI options, with regression checks that catch future drift.

Do we have a high-confidence way to reproduce the issue?

Yes. Current main visibly omits registered locales from fish completions, and the prior completed review records before-and-after fish output; this review did not execute the CLI.

Is this the best way to solve the issue?

Yes. Updating the existing completion file and checking it against the locale registry is a narrow repair for the documented CLI behavior.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against ed7d536fd079.

Labels

Label changes:

No label changes.

Label justifications:

• P3: This repairs shell discoverability and documentation without changing command execution or stored settings.
• rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (terminal): The prior completed review records a contributor terminal transcript exercising the changed fish rules and observing corrected locale and command suggestions. The latest head adds a fish execution test without changing those production rules; no stored-data contract changes.
• proof: sufficient: Contributor real behavior proof is sufficient. The prior completed review records a contributor terminal transcript exercising the changed fish rules and observing corrected locale and command suggestions. The latest head adds a fish execution test without changing those production rules; no stored-data contract changes.

Evidence

What I checked:

• Repository policy: The full root policy was read; no nested AGENTS.md or matching maintainer notes were found. Its CLI and core ownership guidance informed the review. (AGENTS.md:1, 8d2f3ac2371e)
• Introduced completion behavior: The pinned PR delta adds registered locale candidates across command contexts and prevents daemon child commands from appearing after an option token. (completions/summarize.fish:39, 8d2f3ac2371e)
• Existing CLI contract: The shared catalog registers 14 interface locales; the CLI resolves locale before dispatch and removes locale arguments before subcommand handling. (packages/core/src/localization/messages.ts:26, ed7d536fd079)
• Current main and release check: Both pinned main and v0.23.0 retain the short locale list; neither contains this completion repair. (completions/summarize.fish:85, 7ce8f68b9daa)
• Latest regression coverage: The latest commit adds a fish syntax check and exercises locale completion for both executable names and the daemon context. It changes tests, not the completion rules reviewed previously. (tests/package-bin.test.ts:229, 8d2f3ac2371e)
• Previously reviewed behavior proof: The completed review at fix(cli): sync fish completions and command docs with locale surface #486 (comment) records a contributor terminal transcript showing corrected fish candidates for locale, daemon installation, and status at the prior head. The current PR body summarizes that validation but no longer includes the transcript. (d9f906367be0)

Likely related people:

• vincent-peng: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)
• steipete: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score	Internal tier	Crab rank	Meaning
6/6	S	🦀 challenger crab	Exceptional readiness
5/6	A	🦞 diamond lobster	Very strong readiness
4/6	B	🐚 platinum hermit	Good normal PR; ordinary maintainer review
3/6	C	🦐 gold shrimp	Useful, but confidence is limited
2/6	D	🦪 silver shellfish	Proof or implementation needs work
1/6	F	🧂 unranked krab	Not merge-ready
N/A	NA	🌊 off-meta tidepool	Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (1 earlier review cycle)

• reviewed 2026-09-22T10:28:00.887Z sha d9f9063 :: needs maintainer review before merge. :: none