Build universal binary by default for Intel Mac support#331
Open
JimLiuxinghai wants to merge 1 commit intosteipete:mainfrom
Open
Build universal binary by default for Intel Mac support#331JimLiuxinghai wants to merge 1 commit intosteipete:mainfrom
JimLiuxinghai wants to merge 1 commit intosteipete:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Body:
Summary
Changes the default build behavior to create universal binaries (arm64 + x86_64) instead of host-architecture-only builds, enabling Intel Mac support out of the box.
Changes
Scripts/package_app.sh: DefaultARCH_LISTtoarm64 x86_64instead of host architecture detectionScripts/compile_and_run.sh: DefaultARCHES_VALUEto "arm64 x86_64" instead ofuname -mWhy
Previously, the build scripts only compiled for the host architecture, which meant:
This change ensures that both architectures are always included in the build, making the app work on both Intel and Apple Silicon Macs regardless of where it was built.
Backward Compatibility
Users can still override this behavior via the
ARCHESenvironment variable:ARCHES="arm64" ./Scripts/package_app.sh # Apple Silicon only
ARCHES="x86_64" ./Scripts/package_app.sh # Intel only
Testing