fix: use @stdlib/utils/push for typed array support in DSV parser #9817
+3
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
Fixes a crash in
@stdlib/utils/dsv/base/parsewhen a TypedArray is provided as therowBufferoption. The_setFieldmethod was callingbuf.push()which throws a TypeError since TypedArrays do not have apushmethod. added the fix suggested in the existing FIXME comment by using@stdlib/utils/push, which supports arrays, typed arrays, and array-like objects.Related Issues
This pull request has the following related issues:
Questions
No.
Checklist
AI Assistance
@stdlib-js/reviewers