[6.x] Delay bulk actions until ready #13450
Merged
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is prevents custom actions like "Generate Social Images" from "popping in" to the floating toolbar prematurely
Member
|
Rather than waiting until they're all available, I added a loading spinner. 
But if the request is fast, you see a flash of the spinner and then the buttons pop in. So, I added a small 300ms delay before showing the bar. If the request is just over 300ms, you might end back up with the original problem. Let's see the feedback from this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #13444.
It was a little tricky to replicate the glitch in the issue, since it doesn't always happen for me.
It seems to happen when initially loading up a page, and on the first render of a custom bulk action.
This PR adds a check to the bulk actions to wait for the data response before showing the floating toolbar.
This fixes things. With this in place, I no longer see the glitch.