apollo_batcher: document why the view call concurrency bound is 32 - #14988
Merged
Merged
Conversation
|
This change is |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
asaf-sw
force-pushed
the
asaf/batcher-view-call-bound-rationale
branch
8 times, most recently
from
August 23, 2026 07:50
7551674 to
970e348
Compare
State the blocking pool the bound is measured against: the node runs a bare `#[tokio::main]`, so the pool holds tokio's default 512 threads, making 32 slots 6.25% of it. Names the other consumers sharing the pool (block_builder execution, block hash computation, the gateway's stateful validator, the transaction converter) so the headroom claim is checkable rather than asserted. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
asaf-sw
force-pushed
the
asaf/batcher-view-call-bound-rationale
branch
from
August 23, 2026 11:12
970e348 to
2d6081d
Compare
asaf-sw
marked this pull request as ready for review
August 23, 2026 11:53
matanl-starkware
approved these changes
Aug 23, 2026
matanl-starkware
left a comment
matanl-starkware
left a comment
Collaborator
There was a problem hiding this comment.
@matanl-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on asaf-sw).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the doc comment on
apollo_batcher'sMAX_CONCURRENT_VIEW_CALLSto state the pool the bound is measured against: the node runs a bare#[tokio::main], so the blocking pool holds tokio's default 512 threads and 32 slots is under 7% of it. Names the other consumers sharing that pool, block builder execution, block hash computation, the gateway's stateful validator and the transaction converter, so the headroom claim is checkable rather than asserted.Comment only. No code, no behavior change, nothing deferred.
Detailed Summary for AI Bots
State the blocking pool the bound is measured against: the node runs a bare
#[tokio::main], so the pool holds tokio's default 512 threads, making 32 slots6.25% of it. Names the other consumers sharing the pool (block_builder execution,
block hash computation, the gateway's stateful validator, the transaction
converter) so the headroom claim is checkable rather than asserted.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com