blockifier,apollo_consensus_orchestrator: avoid state-diff clone in synced-block accessed keys

[gkaempfer]

Summary

Follow-up performance optimization on #14826 (merged), which added accessed-keys computation to try_sync in sequencer_consensus_context.rs.

When fetch_accessed_keys_from_centralized is enabled, try_sync computed the synced block's accessed keys via:

Some(block_data.compute_accessed_keys(&sync_block.state_diff.clone().into()))

sync_block.state_diff is a ThinStateDiff; .clone().into() deep-clones it and converts it into a CommitmentStateDiff purely so compute_accessed_keys (which only reads the state diff by reference) can use it — the clone is thrown away once the call returns, while sync_block (with its original, un-cloned state_diff) is then moved whole into self.deps.batcher.add_sync_block(sync_block, accessed_keys). This clone runs on every synced block once the feature is enabled, at a cost proportional to the block's state-diff size.

Since AccessedKeys::from_call_infos (and the alias-compression prediction it calls into) only ever read the state diff by reference, this PR adds a StateDiffView trait (crates/blockifier/src/state/cached_state.rs) implemented for both CommitmentStateDiff (used when building a block) and ThinStateDiff (used when syncing one), and generalizes AccessedKeys::new/from_call_infos and predicted_alias_storage_entries to accept &impl StateDiffView instead of a concrete &CommitmentStateDiff. compute_accessed_keys now takes &ThinStateDiff directly, and the try_sync call site borrows sync_block.state_diff instead of cloning it.

As a side effect, CommitmentStateDiff::get_contract_addresses — whose only two callers were migrated to the trait's contract_addresses() default method — is now dead and was removed.

All existing callers of AccessedKeys::new (apollo_batcher, starknet_os_flow_tests) pass a concrete &CommitmentStateDiff, which still implements the trait, so they're unaffected.

Test plan

• cargo build -p blockifier, cargo build -p apollo_consensus_orchestrator — clean
• cargo test -p blockifier (state::accessed_keys, state::stateful_compression, including test_predicted_alias_storage_entries_parity) — all pass
• cargo test -p apollo_consensus_orchestrator (cende::, including compute_accessed_keys, and try_sync) — all pass
• cargo check -p apollo_batcher --tests, cargo check -p starknet_os_flow_tests --tests, cargo check -p central_systest_blobs --tests — clean (confirms the other AccessedKeys::new call sites are unaffected)
• cargo clippy -p blockifier -p apollo_consensus_orchestrator -p apollo_batcher --tests --all-targets -- -D warnings — clean
• scripts/rust_fmt.sh — no changes needed
• Reviewed by an independent pass focused on correctness of the field mapping between ThinStateDiff and CommitmentStateDiff (in particular the intentional drop of deprecated_declared_classes, mirroring the existing From<ThinStateDiff> for CommitmentStateDiff impl) and trait design; findings addressed (moved the trait next to CommitmentStateDiff, gave accessors neutral names, deduplicated the repeated address-chain into a default trait method, removed the now-dead get_contract_addresses)

---

Generated by Claude Code

[cursor]

PR Summary

Low Risk
Refactor with equivalent read-only field mapping; existing CommitmentStateDiff callers unchanged. Sync-path behavior when the centralized flag is enabled should match prior logic without the extra clone.

Overview
Avoids deep-cloning the synced block’s ThinStateDiff into a CommitmentStateDiff when computing accessed keys during try_sync (when fetch_accessed_keys_from_centralized is on). The sync path now borrows sync_block.state_diff and passes it through compute_accessed_keys into the batcher’s add_sync_block.

Introduces a StateDiffView trait in blockifier, implemented for both CommitmentStateDiff and ThinStateDiff, and generalizes AccessedKeys::new / from_call_infos and predicted_alias_storage_entries to take &impl StateDiffView. BlockAccessedKeysData::compute_accessed_keys now accepts &ThinStateDiff directly. CommitmentStateDiff::get_contract_addresses is removed in favor of the trait’s contract_addresses().

Tests are updated to use ThinStateDiff in cende accessed-keys tests and to cover try_sync forwarding (or skipping) accessed keys based on the config flag.

^{Reviewed by Cursor Bugbot for commit 20b07d6. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is