ci: cap test parallelism in the prover job to stop the OOM kills - #14957
Open
asaf-sw wants to merge 1 commit into
Open
ci: cap test parallelism in the prover job to stop the OOM kills#14957asaf-sw wants to merge 1 commit into
asaf-sw wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caps test parallelism in the prover job, which is OOM-killed roughly 5 times in 100 runs with zero tests reporting FAILED. The tests take about 27 seconds, so the cap costs little against a 30 minute timeout.
Detailed Summary for AI Bots
Problem
That binary hash is the lib unittest binary from the
Run tests in release modestep, which ran 143 tests with in-memory stwo proving at the runner's default parallelism. The proving integration step below it already uses--test-threads=1for exactly this reason; the same reasoning was never applied here.Observed on run 31484035403.
Change
Cap that step at
--test-threads=4. In a successful run the tests execute in ~27s of a ~3.5 minute step that is nearly all compilation, and recent runs land at 12 to 17 minutes against a 30 minute timeout.