Skip to content

Fix #2275: improve bad _id handling for Tables wrt error#2416

Merged
tatu-at-datastax merged 10 commits intomainfrom
tatu/2275-table-id-bad-error
Mar 4, 2026
Merged

Fix #2275: improve bad _id handling for Tables wrt error#2416
tatu-at-datastax merged 10 commits intomainfrom
tatu/2275-table-id-bad-error

Conversation

@tatu-at-datastax
Copy link
Contributor

What this PR does:

Improves error handling for bad _id case with Tables.

Which issue(s) this PR fixes:
Fixes #2275

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax self-assigned this Mar 3, 2026
@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner March 3, 2026 16:42
@tatu-at-datastax tatu-at-datastax added the Feature - Tables Issue impacts the users of Tables label Mar 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 50.01%
This PR 50.02%
Delta 🟢 +0.00%
✅ Coverage improved!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Unit Test Coverage Report

Overall Project 50.02% -0.03% 🍏
Files changed 57.58%

File Coverage
TableFilterResolver.java 40.6% -5.21%

@tatu-at-datastax tatu-at-datastax changed the title Fix #2275: improve bad _id handling for Tables wrt error (WIP) Fix #2275: improve bad _id handling for Tables wrt error Mar 3, 2026
@tatu-at-datastax tatu-at-datastax marked this pull request as draft March 3, 2026 16:49
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

📈 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 70.33%
This PR 70.35%
Delta 🟢 +0.02%
✅ Coverage improved!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Integration Test Coverage Report (dse69-it)

Overall Project 70.35% 🍏
Files changed 93.94% 🍏

File Coverage
TableFilterResolver.java 83.99% -0.74% 🍏

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

📈 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 72.07%
This PR 72.09%
Delta 🟢 +0.01%
✅ Coverage improved!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Integration Test Coverage Report (hcd-it)

Overall Project 72.09% 🍏
Files changed 93.94% 🍏

File Coverage
TableFilterResolver.java 88.45% -0.74% 🍏

@tatu-at-datastax tatu-at-datastax changed the title (WIP) Fix #2275: improve bad _id handling for Tables wrt error Fix #2275: improve bad _id handling for Tables wrt error Mar 4, 2026
@tatu-at-datastax tatu-at-datastax marked this pull request as ready for review March 4, 2026 17:12
Copy link
Contributor

@Hazel-Datastax Hazel-Datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tatu-at-datastax tatu-at-datastax merged commit 3ea2822 into main Mar 4, 2026
3 checks passed
@tatu-at-datastax tatu-at-datastax deleted the tatu/2275-table-id-bad-error branch March 4, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature - Tables Issue impacts the users of Tables

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading error message when filtering primitive column by object value in tables

2 participants