Skip to content

ci: enforce semantic PR title prefixes - #1233

Merged
jm-stakater merged 3 commits into
v2from
ci/pr-title-check
Sep 29, 2026
Merged

jm-stakater merged 3 commits into
v2from
ci/pr-title-check

Conversation

@msafwankarim

@msafwankarim msafwankarim commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Problem

v2 is now the development branch and master is frozen for fixes and chores only. PR title rules need to be enforced on both branches, and GitHub loads PR workflows from the target branch, so the check has to exist on v2 too.

Solution

Adds pr-title.yaml, identical to the one in the master PR. On v** it accepts feat, fix, chore, docs, refactor, perf, test, ci, build, revert (scope and ! allowed). The bot comment only fires for master PRs. Also adds the "Branches and PR titles" README section.

Also fixes the PR build: the UBI builder image came from the highest tag with its suffix stripped, so v2.0.0-beta.1 became v2.0.0, an image that does not exist. It now uses the highest v2.* tag as is.

Before/After

Title into v2 Before After
feat(chart): add X passes passes
feat!: drop old API passes passes
chart: foo passes fails, no conventional prefix

After merging, mark semantic-prefix as a required check on v2.

Add pr-title.yaml, identical to master, so PR title rules apply to both branches. Document the branch policy in the README.
@github-actions

Copy link
Copy Markdown

✅ Load Test Results (quick)

✅ Load Test Results: ALL TESTS PASSED

🚀 Quick Test (S1, S4, S6) — Use /loadtest for full suite

3/3 passed (100%)

Scenario Description Actions Errors
✅ S1 S1: 142 burst updates, each triggers 1 dep... 142/142 0
✅ S4 S4: 0 no-op updates, all should be skipped 0 0
✅ S6 S6: Restart test - 142 updates during restart 135 0

📦 Download detailed results


Artifacts: Download

@github-actions

Copy link
Copy Markdown

✅ Load Test Results (quick)

✅ Load Test Results: ALL TESTS PASSED

🚀 Quick Test (S1, S4, S6) — Use /loadtest for full suite

3/3 passed (100%)

Scenario Description Actions Errors
✅ S1 S1: 142 burst updates, each triggers 1 dep... 141/142 0
✅ S4 S4: 143 no-op updates, all should be skipped 0 0
✅ S6 S6: Restart test - 142 updates during restart 136 0

📦 Download detailed results


Artifacts: Download

@github-actions

Copy link
Copy Markdown

✅ Load Test Results (quick)

✅ Load Test Results: ALL TESTS PASSED

🚀 Quick Test (S1, S4, S6) — Use /loadtest for full suite

3/3 passed (100%)

Scenario Description Actions Errors
✅ S1 S1: 143 burst updates, each triggers 1 dep... 143/143 0
✅ S4 S4: 143 no-op updates, all should be skipped 0 0
✅ S6 S6: Restart test - 142 updates during restart 136 0

📦 Download detailed results


Artifacts: Download

@jm-stakater
jm-stakater merged commit bf5c844 into v2 Sep 29, 2026
8 checks passed
@jm-stakater
jm-stakater deleted the ci/pr-title-check branch September 29, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants