Skip to content

fix: Add missing hardcoded annotations to override flag - #1228

Open
haosb wants to merge 1 commit into
stakater:masterfrom
haosb:feat/configurable-annotation-keys
Open

haosb wants to merge 1 commit into
stakater:masterfrom
haosb:feat/configurable-annotation-keys

Conversation

@haosb

@haosb haosb commented Sep 22, 2026 •

Copy link
Copy Markdown

Hello, we are using Reloader in a Kubernetes platform and re-expose all annotations under our own domain via the existing --*-annotation flags. But we found that 10 keys are configurable, but 7 are hardcoded, so we end up with a mixed annotation namespace.
This PR fix that and add new flags:

| `--secretproviderclass-annotation` | Overrides `secretproviderclass.reloader.stakater.com/reload` |
| `--secretproviderclass-auto-annotation` | Overrides `secretproviderclass.reloader.stakater.com/auto` |
| `--configmap-exclude-annotation` | Overrides `configmaps.exclude.reloader.stakater.com/reload` |
| `--secret-exclude-annotation` | Overrides `secrets.exclude.reloader.stakater.com/reload` |
| `--secretproviderclass-exclude-annotation` | Overrides `secretproviderclasses.exclude.reloader.stakater.com/reload` |
| `--rollout-strategy-annotation` | Overrides `reloader.stakater.com/rollout-strategy` |
| `--last-reloaded-from-annotation` | Overrides `reloader.stakater.com/last-reloaded-from` |

Defaults are unchanged, so without the new flags behavior is identical.

@haosb
haosb force-pushed the feat/configurable-annotation-keys branch from 6e3a963 to 0d213cf Compare October 21, 2026 17:43
Signed-off-by: Ruslan Usmanov <haoshand.off@gmail.com>
@haosb
haosb force-pushed the feat/configurable-annotation-keys branch from 0d213cf to c6b0acf Compare October 21, 2026 17:45
@haosb

haosb commented Oct 21, 2026

Copy link
Copy Markdown
Author

@Felix-Stakater Hello, I saw that you ran build and it failed, I rebased the branch so it should be fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant