Repository navigation
Conversation
1 of 4 tasks
haosb
force-pushed
the
feat/configurable-annotation-keys
branch
from
October 21, 2026 17:43
6e3a963 to
0d213cf
Compare
Signed-off-by: Ruslan Usmanov <haoshand.off@gmail.com>
haosb
force-pushed
the
feat/configurable-annotation-keys
branch
from
October 21, 2026 17:45
0d213cf to
c6b0acf
Compare
Author
|
@Felix-Stakater Hello, I saw that you ran build and it failed, I rebased the branch so it should be fine now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, we are using Reloader in a Kubernetes platform and re-expose all annotations under our own domain via the existing
--*-annotationflags. But we found that 10 keys are configurable, but 7 are hardcoded, so we end up with a mixed annotation namespace.This PR fix that and add new flags:
Defaults are unchanged, so without the new flags behavior is identical.