fix: remove the resume timer before resuming a paused deployment

[kaanisthatyou]

Fixes #1219

ResumeDeployment removed the timer entry from activeTimers only after the Get of the deployment succeeded. If that Get failed (for example the API server was briefly unavailable when the timer fired), the function returned early and left the already-fired timer in the map. PauseDeployment only calls HandleMissingTimer when there is no entry for the deployment, so the deployment stayed paused and was never retried.

This moves the timer removal to the start of ResumeDeployment. By the time it runs, the timer has either fired or doesn't exist (the HandleMissingTimer path). A failed attempt then leaves no entry behind, and the next change to the deployment goes through HandleMissingTimer again. This also covers the other early returns (IsPausedByReloader false, resume patch creation failing), which had the same problem.

Testing

TestResumeDeploymentRetriesAfterFailedGet uses a fake clientset with a reactor that fails get deployments once, and checks that:

1. after the failed resume, the timer entry is gone;
2. a following PauseDeployment call for the still-paused deployment (pause period expired) resumes it.

The handler package needs a cluster for its test setup, so I ran the suite through the repository's pull request workflow on my fork: https://github.com/kaanisthatyou/Reloader/actions/runs/34899925407. golangci-lint, make test (including --- PASS: TestResumeDeploymentRetriesAfterFailedGet), the E2E tests and the A/B load tests passed. Only "Build Docker UBI Image" failed, because the fork can't pull from its own ghcr.io namespace. Locally, go vet ./internal/pkg/handler/ passes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EcwjgZmx8zbtn6PpwDY9A1

[SyedaFatimaKazmi]

Thank you for your contribution. This is the right fix, and I like that it stays minimal.

I have left two minor comments below. None of them block the merge but they are small additions and a naming point. Happy to merge once you have had a look at them.