Skip to content

ROX-35852: do not alert on openshift-custom-domains.* - #348

Merged
johannes94 merged 1 commit into
masterfrom
jmalsam/ignore-custom-domain-mixins
Aug 4, 2026
Merged

ROX-35852: do not alert on openshift-custom-domains.*#348
johannes94 merged 1 commit into
masterfrom
jmalsam/ignore-custom-domain-mixins

Conversation

@johannes94

Copy link
Copy Markdown
Contributor

The custom domains operator is crashing every now and then on acs-prod-dp-02.

We are not using that operator and are not interested in this alerts. Additionally it is deprecated anyways.

This PR disables alerting for that namespace, to stop the noise in PagerDuty.

@johannes94
johannes94 requested a review from a team as a code owner August 4, 2026 05:05
@johannes94
johannes94 requested review from kurlov and removed request for a team August 4, 2026 05:05
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: cee358cd-749c-475e-8422-62859b132b90

📥 Commits

Reviewing files that changed from the base of the PR and between b281035 and 99f1b66.

⛔ Files ignored due to path filters (2)
  • resources/mixins/kubernetes/generated/alerts.yml is excluded by !**/generated/**
  • resources/prometheus/generated/kubernetes-mixin-alerts.yaml is excluded by !**/generated/**
📒 Files selected for processing (1)
  • resources/mixins/kubernetes/mixin.libsonnet

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated namespace selection to exclude custom OpenShift domain namespaces, preventing unintended monitoring or processing of these resources.

Walkthrough

The Kubernetes mixin updates namespaceSelector to exclude namespaces matching openshift-custom-domains.*.

Changes

Kubernetes namespace filtering

Layer / File(s) Summary
Update namespace selector
resources/mixins/kubernetes/mixin.libsonnet
Adds openshift-custom-domains.* to the namespace exclusion patterns.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: kurlov

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: excluding openshift-custom-domains.* from alerting.
Description check ✅ Passed The description explains the alerting change and its reason, including the unused deprecated operator and PagerDuty noise.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jmalsam/ignore-custom-domain-mixins

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GrimmiMeloni GrimmiMeloni left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johannes94
johannes94 merged commit 5bc49ef into master Aug 4, 2026
2 checks passed
@johannes94
johannes94 deleted the jmalsam/ignore-custom-domain-mixins branch August 4, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants