Export WebGLRenderingContext, WebGLTexture from node-index.js and #263
Open
kartikdutt18 wants to merge 3 commits intostackgl:masterfrom
Open
Export WebGLRenderingContext, WebGLTexture from node-index.js and #263kartikdutt18 wants to merge 3 commits intostackgl:masterfrom
kartikdutt18 wants to merge 3 commits intostackgl:masterfrom
Conversation
cclauss
suggested changes
Aug 29, 2024
| } | ||
|
|
||
| module.exports = createContext | ||
| const { WebGLTexture } = require("./webgl-texture") |
There was a problem hiding this comment.
Suggested change
| const { WebGLTexture } = require("./webgl-texture") | |
| const { WebGLTexture } = require('./webgl-texture') |
and add one and only one blank line to the end of the file to placate standard running on AppVeyor.
- Scroll to the very bottom of https://ci.appveyor.com/project/dhritzkiv/headless-gl/builds/47591784
standard | snazzy && tape test/*.js | faucet
standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Runstandard --fixto automatically fix some problems.
C:\projects\headless-gl\src\javascript\node-index.js
130:34 error Strings must use singlequote quotes
132:43 error Newline required at end of file but not found eol-last
✖ 2 problems
Command exited with code 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,