Drop dead rdoc/markdown handling from rubygems plugin#4
Open
st0012 wants to merge 2 commits into
Open
Conversation
lib/rdoc/markdown.rb is now generated and committed, so the LoadError-handling workaround that delayed hook registration when markdown.rb was absent during rdoc's own `bundle install` is no longer needed. Require markdown unconditionally and register the hooks at top level. https://claude.ai/code/session_01UJr3jZWKpHhtJvdvmSSzzB
st0012
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
The require existed only to gate hook registration via `rescue LoadError` (the previous commit's bootstrap workaround). Once that gate is gone, requiring rdoc/markdown at plugin-load time is dead weight — RDoc::RubyGemsHook never references RDoc::Markdown directly, and any markdown sources actually encountered during doc generation are loaded lazily by the parser dispatcher. https://claude.ai/code/session_01UJr3jZWKpHhtJvdvmSSzzB
st0012
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
st0012
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5e95c0eba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/rubygems_plugin.rbcarries abegin / rescue LoadError / elseblock aroundrequire_relative 'rdoc/markdown', gating hook registration on the require succeeding. The accompanying comment explains the guard exists becausemarkdown.rbused to be kpeg-generated duringbundle installand could be absent mid-bootstrap.That window no longer exists.
lib/rdoc/markdown.rbis generated and committed, andRDoc::RubyGemsHookdoesn't referenceRDoc::Markdownitself — any markdown source actually encountered during doc generation is loaded lazily by the parser dispatcher. So both the guard and the require it gated are dead code.This drops both, and as a side effect skips parsing ~16k LOC of kpeg-generated parser on every
gemCLI invocation and everybundle installresolution path.