Update Workflow to 6.0 and account for ReactiveSwift removal#15
Merged
Conversation
amorde
force-pushed
the
amorde/workflow-reactive-swift
branch
from
July 17, 2026 18:18
692f9a0 to
1f84a69
Compare
johnnewman-square
approved these changes
Jul 17, 2026
Comment on lines
-43
to
+44
| workflowHost.output | ||
| .signal | ||
| .take(during: lifetime) | ||
| .observeValues(onOutput) | ||
| workflowHost.outputPublisher | ||
| .sink(receiveValue: onOutput) | ||
| .store(in: &cancellables) |
Contributor
There was a problem hiding this comment.
At first I thought we'd need to dropFirst() here, but outputPublisher is a PassthroughSubject, so we're all good!
Member
Author
There was a problem hiding this comment.
yep luckily for output we don't need it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump Workflow to 6.0 and address the ReactiveSwift removal from square/workflow-swift#392