Skip to content

test(database) :: test that parameters reach the DB and are cached - #1501

Merged
lovasoa merged 5 commits into
mainfrom
81reap/ci-1474
Oct 1, 2026
Merged

lovasoa merged 5 commits into
mainfrom
81reap/ci-1474

Conversation

@81reap

@81reap 81reap commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Before a bound parameter had to survive a round trip in tests/transactions and in computed_projection_binding_order.sql, but nothing bound one variable twice in a single statement, and nothing asserted that a parameterized page runs as a prepared statement rather than through SQLExecDirect.

Now two tests cover both halves of sqlx-oldapi#57, one of wich covers the INSERT ... SELECT $x WHERE $x IS NOT NULL shape from #1474.


Stack created with GitHub Stacks CLI • Give Feedback 💬

@81reap
81reap added this pull request to stack #1502 September 25, 2026 22:42
Base automatically changed from 81reap/ci-duckdb to main September 26, 2026 12:32
@81reap
81reap force-pushed the 81reap/ci-1474 branch 2 times, most recently from 4159106 to 50d8484 Compare September 26, 2026 14:56
Comment thread tests/parameter_binding/mod.rs Outdated
81reap and others added 5 commits October 1, 2026 15:23
Before a bound parameter had to survive a round trip in `tests/transactions` and in `computed_projection_binding_order.sql`, but nothing bound one variable twice in a single statement, and nothing asserted that a parameterized page runs as a prepared statement rather than through `SQLExecDirect`.

Now two tests cover both halves of [sqlx-oldapi#57](sqlpage/sqlx-oldapi#57), one of wich covers the `INSERT ... SELECT $x WHERE $x IS NOT NULL` shape from #1474.
@lovasoa
lovasoa merged commit 6199e6f into main Oct 1, 2026
52 checks passed
@lovasoa
lovasoa deleted the 81reap/ci-1474 branch October 1, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants