Fix ToolCallback overload selection in ChatClient#6141
Open
juanjuandog wants to merge 1 commit into
Open
Conversation
Signed-off-by: juanjuandog <juanjuandog@users.noreply.github.com>
6a11990 to
462f3d5
Compare
Contributor
Author
|
This still looks clean from my side. The branch is up to date and the checks are green, so I think this is ready for review when you have a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A direct ToolCallback argument to tools(...) binds to Object... today. That sends FunctionToolCallback through the @tool method path and ends with "No @tool annotated methods found".
This adds the specific ToolCallback and ToolCallbackProvider overloads for tools(...) and defaultTools(...), routed through the existing ToolSpec callback path.
Closes #2495
Tests: