Conversation
Trail maintainer and mentoring document go brrrr
|
RemFexxel
left a comment
RemFexxel
left a comment
There was a problem hiding this comment.
Spelling mistakes, redundancy, and improvements, if preferred.
Co-authored-by: Rem <GitRem@grifton.lol>
|
More of an implementation detail but if we do this I'd like a channel on discord where trial maints can post their reviews to ask for feedback or issues they missed. |
Princess-Cheeseballs
left a comment
Princess-Cheeseballs
left a comment
There was a problem hiding this comment.
Some things I noticed
| Additionally, an introductory onboarding session will be held shortly after the applicant has been accepted. | ||
|
|
||
| ## Trial maintainer-ship duration | ||
| (The preliminary trial duration is 2 months. This may be adjusted later, after the first few trials have passed. After the trial period, the assigned mentor presents their opinion on the trial maintainer, and maintainers vote on whether the trial continues, ends, or is accepted as a full maintainer. |
There was a problem hiding this comment.
It could be good to copy from admins and have bi-weekly checkups on their maintainer actions, especially once they get proper merge permissions.
Duration of 2 months is probably fine, but this also implies if they fail the initial 2 month vote they have to wait another 2 months which is a bit of a long wait. Could be best to leave that up to the judgement of their mentor with a minimum of 2 months.
| ## Limitations | ||
| - No PII access (Grafana etc.) | ||
| - No codermin in-game permissions | ||
| - An additional maintainer approval is required for merging PRs until the mentoring maintainer decides they are fit to follow the normal PR review policy. |
There was a problem hiding this comment.
A bit vague? I assume this means they can approve PRs but any PRs they approve require a second maintainer approval always.
Also seems like something where we'd want to wait for them to be promoted before they get full perms.
There was a problem hiding this comment.
I think it makes sense to always have a second maintainer review, but I do think their review should count as a "normal" review just that they can't click the merge button and they can't merge prs with only their approval 🤔
There was a problem hiding this comment.
required for merging PRs until the mentoring maintainer decides they are fit to follow the normal PR review policy.
Is this decision separate from their trialmin status?
There was a problem hiding this comment.
Yes but we are probably going to change that specific paragraph a bit. I didn't have time to address the reviews yet.
They are also normal reviews. What we meant is that if they can get the extra restrictions on merging removed during their trial
7 participants
Trail maintainer and mentoring document go brrrr